[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-26 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r54321396 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala --- @@ -0,0 +1,445 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10705 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-25 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-189066700 Merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-25 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-189052867 LGTM. There are still a few remaining issues about maintainability but they can be addressed in a follow-up patch. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-25 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r54186034 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala --- @@ -0,0 +1,445 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-25 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r54182055 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -452,7 +440,10 @@ private[spark] class BlockManager( if

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-25 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r54181471 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -452,7 +440,10 @@ private[spark] class BlockManager( if

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-25 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r54180953 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -452,7 +440,10 @@ private[spark] class BlockManager( if

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-25 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r54178354 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -452,7 +440,10 @@ private[spark] class BlockManager( if

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-189016298 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-189016300 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-189015891 **[Test build #51987 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51987/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-25 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r54177384 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -452,7 +440,10 @@ private[spark] class BlockManager( if

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-25 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r54177134 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -452,7 +440,10 @@ private[spark] class BlockManager( if

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188999121 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188999118 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188998834 **[Test build #51985 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51985/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188952568 **[Test build #51987 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51987/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-25 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188951622 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188939377 **[Test build #51985 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51985/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-25 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188938451 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188560851 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188560858 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188560682 **[Test build #51910 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51910/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188522589 **[Test build #51910 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51910/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-24 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188521669 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188453371 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188453375 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-24 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188448922 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188443489 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188443477 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188442898 **[Test build #51883 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51883/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188351914 **[Test build #51883 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51883/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-24 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188343375 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188144514 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188144403 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-24 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188138731 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188117398 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188117401 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188117063 **[Test build #51841 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51841/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188114683 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188114685 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188056736 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188056732 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188056620 **[Test build #51821 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51821/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-188048616 **[Test build #51841 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51841/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53889341 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -989,77 +1014,62 @@ private[spark] class BlockManager( * store

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53889224 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala --- @@ -0,0 +1,438 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53889110 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala --- @@ -0,0 +1,438 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53889065 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -989,77 +1014,62 @@ private[spark] class BlockManager( * store

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53888703 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala --- @@ -0,0 +1,438 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53888668 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala --- @@ -0,0 +1,438 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53888620 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala --- @@ -0,0 +1,438 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53888342 --- Diff: core/src/main/scala/org/apache/spark/network/netty/NettyBlockRpcServer.scala --- @@ -65,7 +65,11 @@ class NettyBlockRpcServer( val

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187991486 LGTM Good work! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53877407 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -989,77 +1014,62 @@ private[spark] class BlockManager( * store

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53877424 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -989,77 +1014,62 @@ private[spark] class BlockManager( * store

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53877235 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala --- @@ -0,0 +1,438 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53876818 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala --- @@ -0,0 +1,438 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53876641 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala --- @@ -0,0 +1,438 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53876449 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala --- @@ -0,0 +1,438 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53876330 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala --- @@ -0,0 +1,438 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53876274 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala --- @@ -0,0 +1,438 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53876039 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala --- @@ -0,0 +1,438 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53875856 --- Diff: core/src/main/scala/org/apache/spark/network/netty/NettyBlockRpcServer.scala --- @@ -65,7 +65,11 @@ class NettyBlockRpcServer( val

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187984214 **[Test build #51821 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51821/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187977182 @andrewor14, @nongli: I think that I should have addressed all comments, so this should now be ready for a final review and sign-off. --- If your project is set up

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187971575 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187971574 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187970867 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187970864 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187969914 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187969913 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187968241 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187968235 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187967925 **[Test build #51806 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51806/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53869781 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -521,16 +509,17 @@ private[spark] class BlockManager(

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53869401 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -521,16 +509,17 @@ private[spark] class BlockManager(

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53869169 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -597,6 +586,9 @@ private[spark] class BlockManager( /**

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53869083 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala --- @@ -0,0 +1,356 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187939399 **[Test build #51806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51806/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187904589 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187904592 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187904224 **[Test build #51776 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51776/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187799005 **[Test build #51776 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51776/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187792630 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187689480 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187689477 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187689047 **[Test build #51753 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51753/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187652269 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187652267 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187651889 **[Test build #51748 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51748/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187609632 **[Test build #51753 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51753/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187606736 @andrewor14 and @nongli, thanks for the detailed review. I've addressed most of your comments and only have a few outstanding changes in order to clean up a few more

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53751438 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala --- @@ -0,0 +1,356 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53748113 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala --- @@ -0,0 +1,356 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53747525 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -995,21 +1003,10 @@ private[spark] class BlockManager( data:

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53747428 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala --- @@ -0,0 +1,356 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10705#discussion_r53746834 --- Diff: core/src/test/scala/org/apache/spark/storage/BlockInfoManagerSuite.scala --- @@ -0,0 +1,255 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-12757] Add block-level read/write locks...

2016-02-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-187587361 Test FAILed. Refer to this link for build results (access rights to CI server needed):

  1   2   3   >