Github user blbradley commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-176380347
@maropu I see a corner case in `schemaString`. I believe I can get the
right behavior now.
---
If your project is set up for it, you can reply to this email and
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-176511873
I'll close this pr and I discuss this in #10928.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user maropu closed the pull request at:
https://github.com/apache/spark/pull/10898
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-176511689
I'll close this pr and discuss this in #10928.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user blbradley commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-176232874
@maropu I have submitted an implementation of this in #10928 and am not
getting the error you describe.
---
If your project is set up for it, you can reply to this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-175978667
**[Test build #50251 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50251/consoleFull)**
for PR 10898 at commit
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-175992128
I found that it's not easy to support this type in postgresql in the
current interface of `JdbcDialect`.
This is because the `postgresql-jdbc` implementation cannot
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-176010324
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-176010035
**[Test build #50251 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50251/consoleFull)**
for PR 10898 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-176010326
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user blbradley commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-174528746
You should not be converting to doubles when testing BigDecimal or
DecimalType..
---
If your project is set up for it, you can reply to this email and have your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-174525711
**[Test build #49993 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49993/consoleFull)**
for PR 10898 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-174516038
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-174522086
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user blbradley commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-174529393
Also, we should be handling the precision and scale returned from Postgres.
I've looked deep enough to see that this is possible.
---
If your project is set up for
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-174516035
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-174515843
**[Test build #49989 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49989/consoleFull)**
for PR 10898 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-174639028
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-174639031
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-174547504
ISTM precision and scale returned by postgres are filled with
`ResultSetMetaData.getPrecision` and `ResultSetMetaData.getScale` in `JDBCRDD`.
---
If your project is
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/10898#discussion_r50722428
--- Diff:
docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala
---
@@ -82,6 +83,10 @@ class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-174638686
**[Test build #49998 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49998/consoleFull)**
for PR 10898 at commit
Github user blbradley commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-174574309
@maropu Indeed, but they are not available in the metadata pased to
`dialect.getCatalystType`. They probably need to be added to the metadata and
logic added to
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-174567168
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-174567175
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user blbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10898#discussion_r50717619
--- Diff:
docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala
---
@@ -82,6 +83,10 @@ class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-174566506
**[Test build #49993 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49993/consoleFull)**
for PR 10898 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-174546755
**[Test build #49995 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49995/consoleFull)**
for PR 10898 at commit
Github user blbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10898#discussion_r50716977
--- Diff:
docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala
---
@@ -82,6 +83,10 @@ class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-174601018
**[Test build #49995 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49995/consoleFull)**
for PR 10898 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-174601343
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-174601344
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-174595373
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-174599539
**[Test build #49998 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49998/consoleFull)**
for PR 10898 at commit
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/10898
[SPARK-12966][SQL] Support ArrayType(DecimalType) in Postgre JDBC
The current master throws an exception below;
```
org.postgresql.util.PSQLException: Unable to find server array type for
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10898#issuecomment-174484724
**[Test build #49989 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49989/consoleFull)**
for PR 10898 at commit
36 matches
Mail list logo
