Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/11009#issuecomment-179478292
@marmbrus @cloud-fan @dilipbiswal @yzhou2001 : I have change the code based
on Michael's comments, can you help review it again?
Not sure why the first test
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11009#issuecomment-179477437
**[Test build #50686 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50686/consoleFull)**
for PR 11009 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11009#issuecomment-179513155
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11009#issuecomment-179513148
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11009#issuecomment-179512208
**[Test build #50686 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50686/consoleFull)**
for PR 11009 at commit
GitHub user kevinyu98 reopened a pull request:
https://github.com/apache/spark/pull/11009
[SPARK-12987][SQL]Fixing the name resolution in drop column
@marmbrus @cloud-fan @thomas @jayadevan : Hello All: Can you help review
this code fix?
This problem is coming from drop
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/11009#issuecomment-178738113
Actually, I'd really like to include this in 1.6.1 and this is a nice small
fix. Could you reopen?
---
If your project is set up for it, you can reply to this email
Github user kevinyu98 closed the pull request at:
https://github.com/apache/spark/pull/11009
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/11009#issuecomment-178712237
@marmbrus @cloud-fan @dilipbiswal @yzhou2001 : it seems this is the
duplicate of [SPARK-12988][SQL] Can't drop columns that contain dots #10943, I
will close this
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11009#discussion_r51509057
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
@@ -1257,7 +1257,8 @@ class DataFrame private[sql](
def drop(colNames:
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11009#discussion_r51509060
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
@@ -1257,7 +1257,8 @@ class DataFrame private[sql](
def drop(colNames:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11009#issuecomment-178320218
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11009#issuecomment-178286597
**[Test build #50515 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50515/consoleFull)**
for PR 11009 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11009#issuecomment-178320220
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11009#issuecomment-178319870
**[Test build #50515 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50515/consoleFull)**
for PR 11009 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11009#issuecomment-178279335
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user kevinyu98 opened a pull request:
https://github.com/apache/spark/pull/11009
[SPARK-12987][SQL]Fixing the name resolution in drop column
@marmbrus @cloud-fan @thomas @jayadevan : Hello All: Can you help review
this code fix?
This problem is coming from drop
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/11009#issuecomment-178281031
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11009#issuecomment-178362481
@cloud-fan Yeah.. 10943 also fixes the same issue.
@yzhou2001 Actually the original fix was sort of similar to fix in this PR
except that it also
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/11009#issuecomment-178357731
is it duplicated with https://github.com/apache/spark/pull/10943?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user yzhou2001 commented on the pull request:
https://github.com/apache/spark/pull/11009#issuecomment-178359731
The two jiras seem to be identical; but the fixes are different.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
21 matches
Mail list logo
