[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11083 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186908861 Thanks. I'm going to merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186858134 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186858132 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186857661 **[Test build #51637 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51637/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186856561 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186856563 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186856355 **[Test build #51635 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51635/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186838836 **[Test build #51637 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51637/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186835518 **[Test build #51635 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51635/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186835010 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186835008 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186834561 @rxin I agree that this is stretching the definitions of both `Distribution` and `Partitioning`. We should be able to define the form/shape in which a child node

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r53567175 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange.scala --- @@ -261,10 +266,71 @@ object Exchange { } /** + *

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r53567171 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange.scala --- @@ -261,10 +266,71 @@ object Exchange { } /** + *

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r53567169 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange.scala --- @@ -261,10 +266,71 @@ object Exchange { } /** + *

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r53567059 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashSemiJoin.scala --- @@ -92,3 +78,36 @@ trait HashSemiJoin { }

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186781643 This looks pretty good actually. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r53563803 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashSemiJoin.scala --- @@ -92,3 +78,36 @@ trait HashSemiJoin { } }

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r53563543 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange.scala --- @@ -261,10 +266,71 @@ object Exchange { } /** + * A

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r53563531 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange.scala --- @@ -261,10 +266,71 @@ object Exchange { } /** + * A

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r53563517 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange.scala --- @@ -261,10 +266,71 @@ object Exchange { } /** + * A

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r53563485 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala --- @@ -351,3 +376,21 @@ case class

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r53563479 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala --- @@ -76,6 +77,27 @@ case class

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r53563471 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala --- @@ -213,7 +235,10 @@ case class

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r53563435 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala --- @@ -76,6 +77,27 @@ case class

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186714651 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186714653 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186714591 **[Test build #51605 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51605/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186701179 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186701178 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186700926 **[Test build #51605 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51605/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-20 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r53558837 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/LeftSemiJoinBNL.scala --- @@ -29,22 +29,20 @@ import

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-20 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186683378 @hvanhovell when you get a chance, please update the description if it merits any change. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-20 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186683349 I'm going to review this more carefully tonight. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-20 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r53557395 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/LeftSemiJoinBNL.scala --- @@ -29,22 +29,20 @@ import

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186631469 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186631467 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186631339 **[Test build #51596 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51596/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-186602967 **[Test build #51596 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51596/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-185119397 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-185119401 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-185118291 **[Test build #51418 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51418/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-185082259 **[Test build #51418 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51418/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-16 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-185074026 Retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-185066164 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-185066158 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-185062646 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-185062649 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-16 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-185057987 I renamed the `Exchange` and `Broadcast` operators to `ShuffleExchange` and `BroadcastExchange`. The `BroadcastExchange` operator is now part of `exchange.scala`.

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-16 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-184934782 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-184928430 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-184928429 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-184928190 **[Test build #51386 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51386/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-16 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r53088789 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Broadcast.scala --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-16 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r53088722 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Broadcast.scala --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-184897355 **[Test build #51386 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51386/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-184896683 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-184896680 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r53086324 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Broadcast.scala --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r53075520 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Broadcast.scala --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-15 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r52972187 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Broadcast.scala --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-15 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r52971787 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Broadcast.scala --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-15 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r52971719 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala --- @@ -395,18 +395,31 @@ private[sql] case class

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-15 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r52958555 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala --- @@ -381,6 +381,9 @@ private[sql] case class

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-15 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r52958542 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala --- @@ -391,10 +394,10 @@ private[sql] case class

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-15 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r52957703 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala --- @@ -143,6 +159,14 @@ abstract class SparkPlan extends

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-15 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r52957628 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala --- @@ -395,18 +395,31 @@ private[sql] case class

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-184357639 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-184357640 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-184357435 **[Test build #51320 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51320/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-184350008 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-184350010 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-184349780 **[Test build #51319 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51319/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-184332552 **[Test build #51320 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51320/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-184321533 **[Test build #51319 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51319/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-15 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-184321267 I moved the index creation into the BroadcastMode (Perhaps we should change the name). --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-184012646 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-184012648 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-184012573 **[Test build #51283 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51283/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-183999896 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-183999899 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-14 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r52850870 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -47,75 +42,40 @@ case class BroadcastHashJoin(

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-14 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-183999269 I have removed the closure from the `BroadcastDistribution`. We now depend on `BroadcastMode`s to determine the kind of index to build. The actual index creating

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-184000577 **[Test build #51283 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51283/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-182511203 **[Test build #51039 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51039/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-182544261 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-182544266 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-182543784 **[Test build #51039 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51039/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-10 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-182732869 @yhuai if you have some time this wk, can you review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r52566924 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala --- @@ -76,6 +77,12 @@ case class

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r52566997 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -47,75 +42,40 @@ case class BroadcastHashJoin(

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11083#discussion_r52207039 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Broadcast.scala --- @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-181529650 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-181529648 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-181529198 **[Test build #50928 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50928/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-08 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-181493342 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-181499226 **[Test build #50928 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50928/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-181586670 **[Test build #50942 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50942/consoleFull)** for PR 11083 at commit

[GitHub] spark pull request: [SPARK-13136][SQL] Create a dedicated Broadcas...

2016-02-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11083#issuecomment-181619429 **[Test build #50942 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50942/consoleFull)** for PR 11083 at commit

  1   2   >