Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11260
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188390037
Looks good, merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188344469
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188344458
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188344019
**[Test build #51882 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51882/consoleFull)**
for PR 11260 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188302330
**[Test build #51882 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51882/consoleFull)**
for PR 11260 at commit
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188297160
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188257864
It is weird. Some other PRs like #11344 (just document change) also failed
at this SparkR unit tests.
---
If your project is set up for it, you can reply to this email
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188212965
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188212970
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188212474
**[Test build #51868 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51868/consoleFull)**
for PR 11260 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188175586
**[Test build #51868 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51868/consoleFull)**
for PR 11260 at commit
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188171128
Failure (at test_mllib.R#133): kmeans ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188170993
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188155543
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188155538
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188155198
**[Test build #51858 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51858/consoleFull)**
for PR 11260 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188130127
**[Test build #51858 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51858/consoleFull)**
for PR 11260 at commit
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188074445
I think the failed test is caused by updated column pruning rule.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188064958
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188064959
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188064780
**[Test build #51842 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51842/consoleFull)**
for PR 11260 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188046410
**[Test build #51842 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51842/consoleFull)**
for PR 11260 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188043855
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188041663
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-188041666
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11260#discussion_r53888103
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala
---
@@ -92,4 +92,30 @@ class JoinOrderSuite
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187831120
Implementation LGTM overall, minor comment on tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11260#discussion_r53824942
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala
---
@@ -92,4 +92,30 @@ class JoinOrderSuite
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187670946
@rxin I've addressed your comments. Please see if this is appropriate.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187670130
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187670129
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187669920
**[Test build #51763 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51763/consoleFull)**
for PR 11260 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187639017
**[Test build #51763 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51763/consoleFull)**
for PR 11260 at commit
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187631523
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187630910
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187630909
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187626059
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187621826
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187621830
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187611637
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187586197
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187586195
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187585367
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187585365
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187583899
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187583900
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187583894
**[Test build #51743 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51743/consoleFull)**
for PR 11260 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187579855
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187579858
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187579379
**[Test build #51738 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51738/consoleFull)**
for PR 11260 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187578291
**[Test build #51743 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51743/consoleFull)**
for PR 11260 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187577629
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11260#discussion_r53743303
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
@@ -137,6 +139,22 @@ class JoinSuite extends QueryTest with
SharedSQLContext {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187577622
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11260#discussion_r53743187
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -81,11 +81,13 @@ private[sql] abstract class SparkStrategies
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11260#discussion_r53743134
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
@@ -137,6 +139,22 @@ class JoinSuite extends QueryTest with
SharedSQLContext {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187574944
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187574948
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187574635
**[Test build #51731 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51731/consoleFull)**
for PR 11260 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187552861
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187552856
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187552314
**[Test build #51726 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51726/consoleFull)**
for PR 11260 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187551375
**[Test build #51738 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51738/consoleFull)**
for PR 11260 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11260#discussion_r53738663
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ColumnPruningSuite.scala
---
@@ -125,5 +125,31 @@ class ColumnPruningSuite
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11260#discussion_r53738587
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ColumnPruningSuite.scala
---
@@ -125,5 +125,31 @@ class ColumnPruningSuite
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187543718
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187543719
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187543500
**[Test build #51724 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51724/consoleFull)**
for PR 11260 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187543222
**[Test build #51731 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51731/consoleFull)**
for PR 11260 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11260#discussion_r53736870
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ColumnPruningSuite.scala
---
@@ -125,5 +125,31 @@ class ColumnPruningSuite
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11260#discussion_r53736860
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -82,7 +82,6 @@ private[sql] abstract class SparkStrategies
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187535784
Indeed. We can now. Will update it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187529295
We can remove the old broadcast hint matching in strategy now, can't we?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187519260
**[Test build #51726 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51726/consoleFull)**
for PR 11260 at commit
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187517033
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187516856
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187516852
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187515497
**[Test build #51724 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51724/consoleFull)**
for PR 11260 at commit
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187464173
@rxin @marmbrus that is good idea. Let me update this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187431085
I still don't like this approach and find it too hacky.
I talked to @marmbrus more offline, and maybe it's easiest to just rely on
stats overriding, e.g. when
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187430709
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187430711
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187430428
**[Test build #51672 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51672/consoleFull)**
for PR 11260 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187396775
**[Test build #51672 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51672/consoleFull)**
for PR 11260 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187306447
This feels kind of hacky to me. @rxin why doesn't the hint just change the
statistics again?
---
If your project is set up for it, you can reply to this email and
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187248842
It could be caused by the build failure. The shade JAR is too large now.
After merging the latest build, I hit an issue when using mvn.
---
If your project is set
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187186887
Why jenkins can't retest?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187164890
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187098182
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187040244
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187011421
**[Test build #51659 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51659/consoleFull)**
for PR 11260 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187011434
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187011428
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187010823
**[Test build #51659 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51659/consoleFull)**
for PR 11260 at commit
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187005053
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187001554
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11260#issuecomment-187001550
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11260#discussion_r53585015
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -260,6 +260,20 @@ case class Join(
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11260#discussion_r53582665
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -260,6 +260,20 @@ case class Join(
1 - 100 of 119 matches
Mail list logo
