Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-197720740
**[Test build #53397 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53397/consoleFull)**
for PR 11297 at commit
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-197560109
cc @marmbrus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-197750038
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-197974133
LGTM. Thanks!
Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r56426148
--- Diff:
sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/FromClauseParser.g
---
@@ -91,10 +91,17 @@ fromClause
joinSource
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-197978987
@marmbrus Thank you very much Michael !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r56459052
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1329,48 +1329,72 @@ class Analyzer(
}
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-197750031
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r56421281
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1329,48 +1329,72 @@ class Analyzer(
}
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-197749675
**[Test build #53397 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53397/consoleFull)**
for PR 11297 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11297
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-196660958
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-196660960
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-196660444
**[Test build #53154 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53154/consoleFull)**
for PR 11297 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-196635689
**[Test build #53154 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53154/consoleFull)**
for PR 11297 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-196601404
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-196601382
**[Test build #53145 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53145/consoleFull)**
for PR 11297 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-196601409
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-196598285
**[Test build #53145 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53145/consoleFull)**
for PR 11297 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-196597773
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r56101664
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1339,43 +1339,68 @@ class Analyzer(
*/
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r56101632
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
@@ -458,43 +458,14 @@ class DataFrame private[sql](
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r56101653
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1339,43 +1339,68 @@ class Analyzer(
*/
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r56101613
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2178,4 +2178,62 @@ class SQLQuerySuite extends QueryTest with
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r56101451
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1169,6 +1170,7 @@ object PushPredicateThroughJoin
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-196479791
Oh, you already did :) Ignore that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-196479175
This looks pretty good. Thanks for working on it! Can you also update the
the function in
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r56057338
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1339,43 +1339,68 @@ class Analyzer(
*/
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r56057244
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1339,43 +1339,68 @@ class Analyzer(
*/
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r56057116
--- Diff:
sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/FromClauseParser.g
---
@@ -91,10 +91,17 @@ fromClause
joinSource
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-196475952
We should also modify the [`resolved` attribute of a
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r56056572
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
@@ -458,43 +458,14 @@ class DataFrame private[sql](
Join(logicalPlan,
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r56056454
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2178,4 +2178,62 @@ class SQLQuerySuite extends QueryTest with
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r56056326
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1169,6 +1170,7 @@ object PushPredicateThroughJoin
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-195015526
@gatorsmile Thanks !! I have rebased the code now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-195014561
@marmbrus Hi Michael, i have changed the code per your feedback. As part of
this change, i have also cleaned up dataframe's using join to make use of the
new code.
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r55589677
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -72,6 +72,19 @@ case class
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r55569500
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -72,6 +72,19 @@ case class
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-194451801
@dilipbiswal Could you please resolve the conflicts? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-190338300
@rxin Hi Reynold, would appreciate your feedback on this PR. Thanks a lot.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-187014299
@rxin @adrian-wang Can you please review the implementation and let me know
your comments.Thanks !!
---
If your project is set up for it, you can reply to this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-186992843
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/11297
[SPARK-13427][SQL] Support USING clause in JOIN.
## What changes were proposed in this pull request?
Support queries that JOIN tables with USING clause.
SELECT * from table1 JOIN
43 matches
Mail list logo
