Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-207048048
Good point, let's expose the solver for now. I made a JIRA:
https://issues.apache.org/jira/browse/SPARK-14461
---
If your project is set up for it, you can reply to
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-207016359
So if we included something like the following in an example, it should be
clear what's happening
```Scala
val trainingSummary = lrModel.summary
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-207004666
@jkbradley, adding those methods would make it a little more usable I
think. Another option might be to just add a method to return the solver used,
and then the
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-206566624
By the way, what do you think about providing methods to test if data are
available?
E.g.,
```
/** Indicates if [[coefficientStandardErrors()]] is
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-206515873
LGTM
Merging with master
Thanks very much!
Could you please create a JIRA for updating JavaWrapper and JavaCallable?
---
If your project is set up
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11621
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-206516989
Cool, thanks!
> Could you please create a JIRA for updating JavaWrapper and JavaCallable?
Will do
---
If your project is set up for it, you can reply
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r58762595
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -777,10 +777,10 @@ sealed trait
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-206451858
@jkbradley I incorporated the latest feedback, please take another look
when you get a chance, thanks!
---
If your project is set up for it, you can reply to
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-206071038
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-206071034
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-206070844
**[Test build #55055 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55055/consoleFull)**
for PR 11621 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-206039464
**[Test build #55055 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55055/consoleFull)**
for PR 11621 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-206032471
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-206032447
**[Test build #55038 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55038/consoleFull)**
for PR 11621 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-206032472
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-206029929
**[Test build #55038 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55038/consoleFull)**
for PR 11621 at commit
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-206028397
jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r58629672
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -777,10 +777,10 @@ sealed trait
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-206001580
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-206001577
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-205547478
@BryanCutler Thanks for the updates! They look good. I just commented on
some of the discussions above.
---
If your project is set up for it, you can reply to
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r58467928
--- Diff: python/pyspark/ml/regression.py ---
@@ -151,6 +151,228 @@ def intercept(self):
"""
return self._call_java("intercept")
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r58467841
--- Diff: python/pyspark/ml/regression.py ---
@@ -151,6 +151,209 @@ def intercept(self):
"""
return self._call_java("intercept")
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r58467586
--- Diff: python/pyspark/ml/tests.py ---
@@ -238,6 +238,17 @@ def setParams(self, seed=None):
return self._set(**kwargs)
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r58467127
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -539,6 +539,10 @@ class LinearRegressionTrainingSummary
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r58466790
--- Diff: python/pyspark/ml/wrapper.py ---
@@ -190,8 +190,30 @@ def _transform(self, dataset):
return
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-205535414
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-205535415
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-205535269
**[Test build #54900 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54900/consoleFull)**
for PR 11621 at commit
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r58462597
--- Diff: python/pyspark/ml/regression.py ---
@@ -151,6 +151,209 @@ def intercept(self):
"""
return
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r58460722
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -539,6 +539,10 @@ class LinearRegressionTrainingSummary
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r58460300
--- Diff: python/pyspark/ml/regression.py ---
@@ -151,6 +151,228 @@ def intercept(self):
"""
return
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r58459975
--- Diff: python/pyspark/ml/tests.py ---
@@ -238,6 +238,17 @@ def setParams(self, seed=None):
return self._set(**kwargs)
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r58459708
--- Diff: python/pyspark/ml/wrapper.py ---
@@ -190,8 +190,30 @@ def _transform(self, dataset):
return
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-205520991
**[Test build #54900 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54900/consoleFull)**
for PR 11621 at commit
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r58079097
--- Diff: python/pyspark/ml/regression.py ---
@@ -151,6 +151,209 @@ def intercept(self):
"""
return self._call_java("intercept")
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r58078950
--- Diff: python/pyspark/ml/regression.py ---
@@ -151,6 +151,209 @@ def intercept(self):
"""
return self._call_java("intercept")
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r57976400
--- Diff: python/pyspark/ml/regression.py ---
@@ -151,6 +151,209 @@ def intercept(self):
"""
return self._call_java("intercept")
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-203640655
I had several minor comments, and there were 2 missing methods. Otherwise,
it's looking good.
---
If your project is set up for it, you can reply to this email and
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r57965947
--- Diff: python/pyspark/ml/regression.py ---
@@ -151,6 +151,209 @@ def intercept(self):
"""
return self._call_java("intercept")
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r57965964
--- Diff: python/pyspark/ml/regression.py ---
@@ -151,6 +151,209 @@ def intercept(self):
"""
return self._call_java("intercept")
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r57965972
--- Diff: python/pyspark/ml/tests.py ---
@@ -238,6 +238,17 @@ def setParams(self, seed=None):
return self._set(**kwargs)
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r57965953
--- Diff: python/pyspark/ml/regression.py ---
@@ -151,6 +151,209 @@ def intercept(self):
"""
return self._call_java("intercept")
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r57965849
--- Diff: python/pyspark/ml/classification.py ---
@@ -28,6 +28,7 @@
__all__ = ['LogisticRegression', 'LogisticRegressionModel',
+
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r57965932
--- Diff: python/pyspark/ml/classification.py ---
@@ -233,6 +234,210 @@ def intercept(self):
"""
return
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r57965908
--- Diff: python/pyspark/ml/classification.py ---
@@ -233,6 +234,210 @@ def intercept(self):
"""
return
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r57965926
--- Diff: python/pyspark/ml/classification.py ---
@@ -233,6 +234,210 @@ def intercept(self):
"""
return
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r57965913
--- Diff: python/pyspark/ml/classification.py ---
@@ -233,6 +234,210 @@ def intercept(self):
"""
return
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r57965918
--- Diff: python/pyspark/ml/classification.py ---
@@ -233,6 +234,210 @@ def intercept(self):
"""
return
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r57965893
--- Diff: python/pyspark/ml/classification.py ---
@@ -233,6 +234,210 @@ def intercept(self):
"""
return
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r57965857
--- Diff: python/pyspark/ml/classification.py ---
@@ -233,6 +234,210 @@ def intercept(self):
"""
return
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r57958007
--- Diff: python/pyspark/ml/wrapper.py ---
@@ -190,8 +190,30 @@ def _transform(self, dataset):
return
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r57661783
--- Diff: python/pyspark/ml/wrapper.py ---
@@ -190,8 +190,30 @@ def _transform(self, dataset):
return
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r57453380
--- Diff: python/pyspark/ml/wrapper.py ---
@@ -190,8 +190,30 @@ def _transform(self, dataset):
return
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-201065047
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-201064969
**[Test build #54108 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54108/consoleFull)**
for PR 11621 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-201065045
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-201060245
Made `JavaModel` inherit `JavaCallable`, please take a look when you get a
chance @jkbradley and see if this change is ok, thanks!
---
If your project is set up
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-201059864
**[Test build #54108 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54108/consoleFull)**
for PR 11621 at commit
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r57362618
--- Diff: python/pyspark/ml/wrapper.py ---
@@ -223,3 +223,20 @@ def _call_java(self, name, *args):
sc = SparkContext._active_spark_context
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r57275251
--- Diff: python/pyspark/ml/wrapper.py ---
@@ -223,3 +223,20 @@ def _call_java(self, name, *args):
sc = SparkContext._active_spark_context
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r57274042
--- Diff: python/pyspark/ml/classification.py ---
@@ -231,6 +232,210 @@ def intercept(self):
"""
return
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r56698060
--- Diff: python/pyspark/ml/wrapper.py ---
@@ -223,3 +223,20 @@ def _call_java(self, name, *args):
sc = SparkContext._active_spark_context
Github user thunterdb commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-198108360
@BryanCutler thanks for the PR, I only have a few small comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-197482757
**[Test build #53335 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53335/consoleFull)**
for PR 11621 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-197492294
**[Test build #53335 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53335/consoleFull)**
for PR 11621 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-198026652
**[Test build #53449 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53449/consoleFull)**
for PR 11621 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-198026901
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r56587628
--- Diff: python/pyspark/ml/classification.py ---
@@ -231,6 +232,210 @@ def intercept(self):
"""
return
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r56384119
--- Diff: python/pyspark/ml/wrapper.py ---
@@ -34,10 +34,12 @@ class JavaWrapper(Params):
__metaclass__ = ABCMeta
-#: The
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r56587642
--- Diff: python/pyspark/ml/classification.py ---
@@ -231,6 +232,210 @@ def intercept(self):
"""
return
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r56697758
--- Diff: python/pyspark/ml/classification.py ---
@@ -231,6 +232,210 @@ def intercept(self):
"""
return
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-197492522
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-198474378
Thanks for checking this out and the comments @thunterdb!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r56587676
--- Diff: python/pyspark/ml/wrapper.py ---
@@ -223,3 +223,20 @@ def _call_java(self, name, *args):
sc = SparkContext._active_spark_context
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-198019144
**[Test build #53449 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53449/consoleFull)**
for PR 11621 at commit
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r56587656
--- Diff: python/pyspark/ml/regression.py ---
@@ -151,6 +151,209 @@ def intercept(self):
"""
return self._call_java("intercept")
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-198026904
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-197492525
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-195123720
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-195123600
**[Test build #52875 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52875/consoleFull)**
for PR 11621 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-195123722
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-195120451
**[Test build #52875 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52875/consoleFull)**
for PR 11621 at commit
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r55774471
--- Diff: python/pyspark/ml/wrapper.py ---
@@ -34,10 +34,12 @@ class JavaWrapper(Params):
__metaclass__ = ABCMeta
-#: The
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-194611784
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-194611779
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-194611410
**[Test build #52798 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52798/consoleFull)**
for PR 11621 at commit
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r55621515
--- Diff: python/pyspark/mllib/common.py ---
@@ -130,20 +130,39 @@ def callMLlibFunc(name, *args):
return callJavaFunc(sc, api, *args)
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-194603492
**[Test build #52798 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52798/consoleFull)**
for PR 11621 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-194586855
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-194586858
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-194586744
**[Test build #52782 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52782/consoleFull)**
for PR 11621 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11621#issuecomment-194581849
**[Test build #52782 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52782/consoleFull)**
for PR 11621 at commit
GitHub user BryanCutler opened a pull request:
https://github.com/apache/spark/pull/11621
[SPARK-13430][PySpark][ML] Python API for training summaries of linear and
logistic regression
## What changes were proposed in this pull request?
Adding Python API for training
95 matches
Mail list logo
