Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11684
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-202500100
LGTM, merging into master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-202014919
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-202014920
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-202014884
**[Test build #54281 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54281/consoleFull)**
for PR 11684 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-202002017
**[Test build #54281 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54281/consoleFull)**
for PR 11684 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-201991658
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-201991655
**[Test build #54275 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54275/consoleFull)**
for PR 11684 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-201991657
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-201991629
**[Test build #54275 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54275/consoleFull)**
for PR 11684 at commit
Github user kiszk commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-201859532
@davies , I resolved conflicts. Would it be possible to review it again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-201855094
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-201855093
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-201854748
**[Test build #54263 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54263/consoleFull)**
for PR 11684 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-201824453
**[Test build #54263 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54263/consoleFull)**
for PR 11684 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-198081329
**[Test build #53467 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53467/consoleFull)**
for PR 11684 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-197491086
**[Test build #53327 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53327/consoleFull)**
for PR 11684 at commit
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11684#discussion_r56397095
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -237,21 +237,44 @@ case class Divide(left:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-198115143
**[Test build #53469 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53469/consoleFull)**
for PR 11684 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-198111782
**[Test build #53467 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53467/consoleFull)**
for PR 11684 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-197491610
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11684#discussion_r56379211
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -199,7 +199,12 @@ case class Divide(left: Expression,
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11684#discussion_r56397286
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -325,22 +338,72 @@ case class Or(left: Expression,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-198115646
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-198112027
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-197443339
**[Test build #53327 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53327/consoleFull)**
for PR 11684 at commit
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11684#discussion_r56378886
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -325,22 +378,76 @@ case class Or(left: Expression,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-197491599
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11684#discussion_r56378963
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -274,22 +274,75 @@ case class And(left: Expression,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-198115650
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-198112026
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-198085859
**[Test build #53469 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53469/consoleFull)**
for PR 11684 at commit
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11684#discussion_r56378913
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -274,22 +274,75 @@ case class And(left: Expression,
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11684#discussion_r56205083
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -325,22 +378,76 @@ case class Or(left: Expression,
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11684#discussion_r56204833
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -274,22 +274,75 @@ case class And(left: Expression,
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11684#discussion_r56204538
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -274,22 +274,75 @@ case class And(left: Expression,
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11684#discussion_r56202965
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -199,7 +199,12 @@ case class Divide(left:
Github user kiszk commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-196594612
@davies, could you please review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-195930295
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-195930296
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-195929790
**[Test build #53026 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53026/consoleFull)**
for PR 11684 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11684#issuecomment-195915534
**[Test build #53026 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53026/consoleFull)**
for PR 11684 at commit
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/11684
[SPARK-13844][SQL] Generate better code for filters with a non-nullable
column
## What changes were proposed in this pull request?
This PR simplifies generated code with a non-nullable
43 matches
Mail list logo
