[GitHub] spark pull request: [SPARK-14081][SQL] - Update DataFrameNaFunctio...

2016-03-30 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11967#issuecomment-203660919 LGTM - we should merge this as soon as you update the title. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] spark pull request: [SPARK-14081][SQL] - Update DataFrameNaFunctio...

2016-03-30 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11967#issuecomment-203660459 @traviscrawford can you update the pr title to have a full sentence? github is cutting it off. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-14081][SQL] - Update DataFrameNaFunctio...

2016-03-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11967#issuecomment-203499196 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14081][SQL] - Update DataFrameNaFunctio...

2016-03-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11967#issuecomment-203499202 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14081][SQL] - Update DataFrameNaFunctio...

2016-03-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11967#issuecomment-203498607 **[Test build #54523 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54523/consoleFull)** for PR 11967 at commit [`9dfe2dd`](https://g

[GitHub] spark pull request: [SPARK-14081][SQL] - Update DataFrameNaFunctio...

2016-03-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11967#issuecomment-203455583 **[Test build #54523 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54523/consoleFull)** for PR 11967 at commit [`9dfe2dd`](https://gi

[GitHub] spark pull request: [SPARK-14081][SQL] - Update DataFrameNaFunctio...

2016-03-25 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11967#discussion_r57505626 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala --- @@ -402,13 +404,7 @@ final class DataFrameNaFunctions private[sql](df: Da

[GitHub] spark pull request: [SPARK-14081][SQL] - Update DataFrameNaFunctio...

2016-03-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11967#issuecomment-201620355 Looks like there is a test failure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request: [SPARK-14081][SQL] - Update DataFrameNaFunctio...

2016-03-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11967#issuecomment-201619013 @traviscrawford can you remove the part about this is your first contribution from the pr description? The pr description will actually become part of the commit. --- I

[GitHub] spark pull request: [SPARK-14081][SQL] - Update DataFrameNaFunctio...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11967#issuecomment-201561249 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14081][SQL] - Update DataFrameNaFunctio...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11967#issuecomment-201561253 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14081][SQL] - Update DataFrameNaFunctio...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11967#issuecomment-201560846 **[Test build #54216 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54216/consoleFull)** for PR 11967 at commit [`834ee69`](https://g

[GitHub] spark pull request: [SPARK-14081][SQL] - Update DataFrameNaFunctio...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11967#issuecomment-201512125 **[Test build #54216 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54216/consoleFull)** for PR 11967 at commit [`834ee69`](https://gi

[GitHub] spark pull request: [SPARK-14081][SQL] - Update DataFrameNaFunctio...

2016-03-25 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11967#issuecomment-201509245 Jenkins, this is ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14081][SQL] - Update DataFrameNaFunctio...

2016-03-25 Thread traviscrawford
Github user traviscrawford commented on a diff in the pull request: https://github.com/apache/spark/pull/11967#discussion_r57490820 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala --- @@ -402,13 +404,7 @@ final class DataFrameNaFunctions private[sq

[GitHub] spark pull request: [SPARK-14081][SQL] - Update DataFrameNaFunctio...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11967#issuecomment-201500484 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-14081][SQL] - Update DataFrameNaFunctio...

2016-03-25 Thread traviscrawford
GitHub user traviscrawford opened a pull request: https://github.com/apache/spark/pull/11967 [SPARK-14081][SQL] - Update DataFrameNaFunctions.fill to preserve column dat… ## What changes were proposed in this pull request? This change resolves an issue where `DataFrameNaFuncti