Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12267#issuecomment-208189630
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12267#issuecomment-208189629
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12267#issuecomment-208189439
Up to now, I updated the followings.
1. Extends `EqualNullSafe` case to handle non-nullable operands.
1. Adds a testcase `Nullable Simplication
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12267#issuecomment-208189477
**[Test build #55505 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55505/consoleFull)**
for PR 12267 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12267#issuecomment-208187631
**[Test build #55511 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55511/consoleFull)**
for PR 12267 at commit
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/12267#issuecomment-208183704
`BinaryComparisonSimplification` LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12267#issuecomment-208181978
@cloud-fan . Thank you so much for improving this PR.
Overall, this PR starts to include one Non-Null case (`EqualNullSafe`) now.
May I change the
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12267#discussion_r59158077
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -787,6 +788,28 @@ object BooleanSimplification
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12267#discussion_r59157332
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NonNullableBinaryComparisonSimplificationSuite.scala
---
@@ -0,0 +1,95 @@
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12267#discussion_r59157076
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NonNullableBinaryComparisonSimplificationSuite.scala
---
@@ -0,0 +1,95 @@
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12267#discussion_r59156961
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -787,6 +788,28 @@ object BooleanSimplification
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12267#issuecomment-208173217
**[Test build #55507 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55507/consoleFull)**
for PR 12267 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12267#discussion_r59156009
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NonNullableBinaryComparisonSimplificationSuite.scala
---
@@ -0,0 +1,99
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12267#discussion_r59155908
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NonNullableBinaryComparisonSimplificationSuite.scala
---
@@ -0,0 +1,99
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12267#discussion_r59155788
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -787,6 +788,28 @@ object BooleanSimplification
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12267#issuecomment-208170041
Thank you for *deep review*, @cloud-fan . :)
I changed PR according to the one comment first.
For the others, I asked some questions to understand more
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12267#discussion_r59155584
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NonNullableBinaryComparisonSimplificationSuite.scala
---
@@ -0,0 +1,99 @@
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12267#issuecomment-208169438
**[Test build #55505 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55505/consoleFull)**
for PR 12267 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12267#discussion_r59155488
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -787,6 +788,28 @@ object BooleanSimplification
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12267#discussion_r59155308
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NonNullableBinaryComparisonSimplificationSuite.scala
---
@@ -0,0 +1,99
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12267#discussion_r59154875
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -787,6 +788,28 @@ object BooleanSimplification
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12267#discussion_r59154150
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NonNullableBinaryComparisonSimplificationSuite.scala
---
@@ -0,0 +1,99
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12267#discussion_r59154120
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -787,6 +788,28 @@ object BooleanSimplification
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12267#discussion_r59147914
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NonNullableBinaryComparisonSimplificationSuite.scala
---
@@ -0,0 +1,99 @@
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12267#discussion_r59146548
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NonNullableBinaryComparisonSimplificationSuite.scala
---
@@ -0,0 +1,99 @@
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12267#discussion_r59146455
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -787,6 +788,28 @@ object BooleanSimplification
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12267#issuecomment-207917458
cc @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12267#issuecomment-207665847
Hi, @rxin .
Could you review this PR please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12267#issuecomment-207661195
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12267#issuecomment-207661197
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12267#issuecomment-207661068
**[Test build #55404 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55404/consoleFull)**
for PR 12267 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12267#issuecomment-207640445
**[Test build #55404 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55404/consoleFull)**
for PR 12267 at commit
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12267
[SPARK-14502][SQL] Add optimization for Non-Nullable Binary Comparison
Simplification
## What changes were proposed in this pull request?
For non-nullable binary comparisons, we can
33 matches
Mail list logo
