Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/12389#issuecomment-210258876
@srowen @rxin thank you for the review & merging! :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12389
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12389#issuecomment-210055510
Merging in master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12389#issuecomment-209892025
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12389#issuecomment-209892021
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12389#issuecomment-209891351
**[Test build #55809 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55809/consoleFull)**
for PR 12389 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12389#issuecomment-209866605
LGTM. It's good practice to make method return types explicit, especially
if they're to be implemented in other classes. This should not change any
behavior since it
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12389#issuecomment-209855113
**[Test build #55809 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55809/consoleFull)**
for PR 12389 at commit
GitHub user lw-lin opened a pull request:
https://github.com/apache/spark/pull/12389
[SPARK-14630][Build][Core][SQL][Streaming] Code style: public abstract
methods should have explicit return types
## What changes were proposed in this pull request?
Currently many public
