Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12646#issuecomment-221025860
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/12646#issuecomment-219164845
retest it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/12646#issuecomment-216018276
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/12646#issuecomment-215462428
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/12646#issuecomment-215444282
retest it please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/12646#issuecomment-214921975
retest please, I just did rebase to resolve the conflicts. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12646#issuecomment-21435
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/12646#issuecomment-214521095
@dongjoon-hyun Hello Dongjoon: I have fix the comments, let me know if you
see anything else I need to change. Also I did git fetch upstream, git merge
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/12646#issuecomment-214465479
Hello Dongjoon: Thanks for your comments, I will make changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12646#issuecomment-214448521
Oh, by the way, Github shows no confilicts but it seems to fail to rebase
to the master.
It might cause some delay when merging. I'm not sure, but you had
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12646#issuecomment-214447695
Although I'm not a committer, I left a few comments since I like your PR,
@kevinyu98 .
---
If your project is set up for it, you can reply to this email and
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r60950803
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1051,6 +1053,22 @@ class AstBuilder extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r60950643
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1051,6 +1053,22 @@ class AstBuilder extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12646#issuecomment-214262362
**[Test build #2867 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2867/consoleFull)**
for PR 12646 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12646#issuecomment-214213556
**[Test build #2867 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2867/consoleFull)**
for PR 12646 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12646#issuecomment-214076564
this this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12646#issuecomment-214073611
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/12646#issuecomment-214038288
Hello : I removed some invalid unit test cases and correct the error
messages in the unit test cases. It passed the local tests. Can you retest it ?
Thanks.
---
If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12646#issuecomment-213947829
**[Test build #2863 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2863/consoleFull)**
for PR 12646 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12646#issuecomment-213927000
**[Test build #2863 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2863/consoleFull)**
for PR 12646 at commit
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/12646#issuecomment-213853674
@hvanhovell @yhuai @chenghao-intel @gatorsmile @dilipbiswal @viirya
@xwu0226 can you help take a look at this PR? Thanks.
---
If your project is set up for it, you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12646#issuecomment-213853045
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user kevinyu98 opened a pull request:
https://github.com/apache/spark/pull/12646
[SPARK-14878][SQL] Trim characters string function support
What changes were proposed in this pull request?
This PR enhances the TRIM function support in Spark SQL by
23 matches
Mail list logo
