Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12739#issuecomment-215452604
I don't feel qualified to evaluate the logic change, but the code style
itself looks OK
---
If your project is set up for it, you can reply to this email and have your
Github user bomeng commented on the pull request:
https://github.com/apache/spark/pull/12739#issuecomment-215450711
@srowen Please review again. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12739#issuecomment-215261696
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12739#issuecomment-215261698
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12739#issuecomment-215261499
**[Test build #57181 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57181/consoleFull)**
for PR 12739 at commit
[`d984b03`](https://g
Github user bomeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12739#discussion_r61342768
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -54,15 +54,22 @@ private[sql] object JDBCRelation
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12739#issuecomment-215242393
**[Test build #57181 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57181/consoleFull)**
for PR 12739 at commit
[`d984b03`](https://gi
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12739#discussion_r61329224
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -54,15 +54,22 @@ private[sql] object JDBCRelation
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12739#discussion_r61328978
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
---
@@ -40,6 +40,16 @@ import org.apache.spark.unsafe.types.U
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12739#issuecomment-215212896
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12739#issuecomment-215212892
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12739#issuecomment-215212520
**[Test build #57157 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57157/consoleFull)**
for PR 12739 at commit
[`b4df4b0`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12739#issuecomment-215188117
**[Test build #57157 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57157/consoleFull)**
for PR 12739 at commit
[`b4df4b0`](https://gi
GitHub user bomeng opened a pull request:
https://github.com/apache/spark/pull/12739
[SPARK-14955] [SQL] avoid stride value equals to zero
## What changes were proposed in this pull request?
In the columnPartition() method of JDBCRelation, stride is used for
calculating the
14 matches
Mail list logo
