Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/12797#discussion_r61775300
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/StreamTest.scala ---
@@ -142,7 +142,10 @@ trait StreamTest extends QueryTest with Timeouts {
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/12797#issuecomment-216309861
Some minor comments about code understandability, but overall this looks
good. Thanks for working on this!
---
If your project is set up for it, you can reply to
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/12797#discussion_r61774969
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/ProcessingTimeExecutorSuite.scala
---
@@ -21,19 +21,41 @@ import
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/12797#discussion_r61774572
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/ProcessingTimeExecutorSuite.scala
---
@@ -21,19 +21,41 @@ import
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/12797#discussion_r61774375
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TriggerExecutor.scala
---
@@ -65,8 +65,22 @@ case class
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/12797#discussion_r61774365
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/StreamTest.scala ---
@@ -280,19 +283,35 @@ trait StreamTest extends QueryTest with Timeouts {
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/12797#discussion_r61773617
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TriggerExecutor.scala
---
@@ -65,8 +65,22 @@ case class
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/12797#discussion_r61771197
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TriggerExecutor.scala
---
@@ -65,8 +65,22 @@ case class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12797#issuecomment-215929410
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12797#issuecomment-215929409
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12797#issuecomment-215929256
**[Test build #57391 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57391/consoleFull)**
for PR 12797 at commit
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/12797#issuecomment-215928373
@marmbrus @tdas @zsxwing would you mind taking a look? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12797#discussion_r61663843
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala ---
@@ -136,6 +136,22 @@ class StreamSuite extends StreamTest with
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12797#discussion_r61663787
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/ProcessingTimeExecutorSuite.scala
---
@@ -21,19 +21,41 @@ import
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12797#issuecomment-215925062
**[Test build #57391 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57391/consoleFull)**
for PR 12797 at commit
GitHub user lw-lin opened a pull request:
https://github.com/apache/spark/pull/12797
[SPARK-15022][SPARK-15023] Add support for testing against the
`ProcessingTime(intervalMS > 0)` trigger and `ManualClock`
## What changes were proposed in this pull request?
Currently in
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/12797#issuecomment-215924685
still editing, will explain why ProcessingTimeExecutor, where for a batch
it should run batchRunner only once but might run multiple times under certain
conditions;
17 matches
Mail list logo
