[GitHub] spark pull request: [SPARK-15087][CORE][SQL] Remove AccumulatorV2....

2016-05-03 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/12865#discussion_r61946906 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -394,7 +394,7 @@ private[spark] class TaskSchedulerImpl(

[GitHub] spark pull request: [SPARK-15087][CORE][SQL] Remove AccumulatorV2....

2016-05-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12865 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15087][CORE][SQL] Remove AccumulatorV2....

2016-05-03 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12865#issuecomment-216624473 Thanks - merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15087][CORE][SQL] Remove AccumulatorV2....

2016-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12865#issuecomment-216553377 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15087][CORE][SQL] Remove AccumulatorV2....

2016-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12865#issuecomment-216553368 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15087][CORE][SQL] Remove AccumulatorV2....

2016-05-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12865#issuecomment-216553092 **[Test build #57637 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57637/consoleFull)** for PR 12865 at commit

[GitHub] spark pull request: [SPARK-15087][CORE][SQL] Remove AccumulatorV2....

2016-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12865#issuecomment-216540724 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15087][CORE][SQL] Remove AccumulatorV2....

2016-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12865#issuecomment-216540728 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15087][CORE][SQL] Remove AccumulatorV2....

2016-05-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12865#issuecomment-216540417 **[Test build #57635 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57635/consoleFull)** for PR 12865 at commit

[GitHub] spark pull request: [SPARK-15087][CORE][SQL] Remove AccumulatorV2....

2016-05-03 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12865#issuecomment-216536103 LGTM, cc @rxin for another look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-15087][CORE][SQL] Remove AccumulatorV2....

2016-05-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12865#issuecomment-216527112 (This is a pretty minor but I think `cc @rxin` can be removed but in the comments because the PR description explains the PR itself and the names of reviewers

[GitHub] spark pull request: [SPARK-15087][CORE][SQL] Remove AccumulatorV2....

2016-05-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12865#issuecomment-216519827 **[Test build #57637 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57637/consoleFull)** for PR 12865 at commit

[GitHub] spark pull request: [SPARK-15087][CORE][SQL] Remove AccumulatorV2....

2016-05-03 Thread techaddict
Github user techaddict commented on a diff in the pull request: https://github.com/apache/spark/pull/12865#discussion_r61875706 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -126,23 +126,9 @@ abstract class AccumulatorV2[IN, OUT] extends

[GitHub] spark pull request: [SPARK-15087][CORE][SQL] Remove AccumulatorV2....

2016-05-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12865#discussion_r61874253 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -126,23 +126,9 @@ abstract class AccumulatorV2[IN, OUT] extends

[GitHub] spark pull request: [SPARK-15087][CORE][SQL] Remove AccumulatorV2....

2016-05-03 Thread techaddict
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/12865#issuecomment-216515443 @cloud-fan fixed 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15087][CORE][SQL] Remove AccumulatorV2....

2016-05-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12865#issuecomment-216515493 **[Test build #57635 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57635/consoleFull)** for PR 12865 at commit

[GitHub] spark pull request: [SPARK-15087][CORE][SQL] Remove AccumulatorV2....

2016-05-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12865#discussion_r61868927 --- Diff: core/src/main/scala/org/apache/spark/AccumulatorV2.scala --- @@ -128,21 +128,7 @@ abstract class AccumulatorV2[IN, OUT] extends Serializable {

[GitHub] spark pull request: [SPARK-15087][CORE][SQL] Remove AccumulatorV2....

2016-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12865#issuecomment-216502889 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15087][CORE][SQL] Remove AccumulatorV2....

2016-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12865#issuecomment-216502890 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15087][CORE][SQL] Remove AccumulatorV2....

2016-05-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12865#issuecomment-216502768 **[Test build #57623 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57623/consoleFull)** for PR 12865 at commit

[GitHub] spark pull request: [SPARK-15087][CORE][SQL] Remove AccumulatorV2....

2016-05-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12865#issuecomment-216487394 **[Test build #57623 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57623/consoleFull)** for PR 12865 at commit

[GitHub] spark pull request: [SPARK-15087][CORE][SQL] Remove AccumulatorV2....

2016-05-03 Thread techaddict
GitHub user techaddict opened a pull request: https://github.com/apache/spark/pull/12865 [SPARK-15087][CORE][SQL] Remove AccumulatorV2.localValue and keep only value ## What changes were proposed in this pull request? Remove AccumulatorV2.localValue and keep only value