Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13045
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220784325
thanks, merging to master and 2.0!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220763498
cc @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220655117
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220655113
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220654844
**[Test build #58999 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58999/consoleFull)**
for PR 13045 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220633250
**[Test build #58999 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58999/consoleFull)**
for PR 13045 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220562032
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220562029
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220561880
**[Test build #58970 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58970/consoleFull)**
for PR 13045 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220546138
**[Test build #58970 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58970/consoleFull)**
for PR 13045 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220544367
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220544365
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220544204
**[Test build #58957 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58957/consoleFull)**
for PR 13045 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220530378
**[Test build #58957 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58957/consoleFull)**
for PR 13045 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13045#discussion_r63996737
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -37,6 +38,14 @@ private[sql] object Column {
def apply(expr: Expression):
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/13045#discussion_r63994025
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -37,6 +38,14 @@ private[sql] object Column {
def apply(expr:
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/13045#discussion_r63992015
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -37,6 +38,14 @@ private[sql] object Column {
def apply(expr:
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/13045#discussion_r63991554
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetAggregatorSuite.scala ---
@@ -240,4 +240,15 @@ class DatasetAggregatorSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13045#discussion_r63991309
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -37,6 +38,14 @@ private[sql] object Column {
def apply(expr: Expression):
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13045#discussion_r63991215
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetAggregatorSuite.scala ---
@@ -240,4 +240,15 @@ class DatasetAggregatorSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13045#discussion_r63991134
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -325,10 +325,13 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13045#discussion_r63991063
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -174,14 +174,16 @@ class Analyzer(
private
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220515698
cc @cloud-fan Hi Wenchen, I have made the changes per your comments. Could
you please look through it when you get a chance ? Thanks..
---
If your project is set
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220456781
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220456786
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220456509
**[Test build #58896 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58896/consoleFull)**
for PR 13045 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220433675
**[Test build #58896 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58896/consoleFull)**
for PR 13045 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220242854
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220242851
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220242701
**[Test build #58850 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58850/consoleFull)**
for PR 13045 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220233152
**[Test build #58850 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58850/consoleFull)**
for PR 13045 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13045#discussion_r63809763
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -326,9 +326,14 @@ case class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220197500
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220197499
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220197302
**[Test build #58822 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58822/consoleFull)**
for PR 13045 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220184467
**[Test build #58822 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58822/consoleFull)**
for PR 13045 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220147299
**[Test build #58809 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58809/consoleFull)**
for PR 13045 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220147651
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220147655
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220128712
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220128719
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220128385
**[Test build #58798 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58798/consoleFull)**
for PR 13045 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220121879
**[Test build #58809 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58809/consoleFull)**
for PR 13045 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-220102264
**[Test build #58798 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58798/consoleFull)**
for PR 13045 at commit
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-219670131
I don't have a good idea either, one possible approach is improving
`UnresolvedAlias` to take a function as the optional alias name, and the
function will take the
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218931189
@cloud-fan Hi Wenchen, can you please look over the change and let me know
what you think ? I had a question for you. I tried to keep the expression
un-resolved
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218930710
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218930711
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218930608
**[Test build #58527 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58527/consoleFull)**
for PR 13045 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218920807
**[Test build #58527 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58527/consoleFull)**
for PR 13045 at commit
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/13045#discussion_r62968394
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -861,11 +861,11 @@ def groupBy(self, *cols):
Each element should be a column name
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13045#discussion_r62967194
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -861,11 +861,11 @@ def groupBy(self, *cols):
Each element should be a column name
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/13045#discussion_r62966720
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -861,11 +861,11 @@ def groupBy(self, *cols):
Each element should be a column name
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13045#discussion_r62966223
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -861,11 +861,11 @@ def groupBy(self, *cols):
Each element should be a column name
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218662623
@yhuai @cloud-fan Sure. I will change it only for typed aggregation.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218661443
How about we just improve the column name of fields generated by typed
aggregation. Seems we are also changing other cases?
---
If your project is set up for it, you
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/13045#discussion_r62965291
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -861,11 +861,11 @@ def groupBy(self, *cols):
Each element should be a column name
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13045#discussion_r62965026
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -861,11 +861,11 @@ def groupBy(self, *cols):
Each element should be a column name
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/13045#discussion_r62964226
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -861,11 +861,11 @@ def groupBy(self, *cols):
Each element should be a column name
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13045#discussion_r62959660
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -861,11 +861,11 @@ def groupBy(self, *cols):
Each element should be a column name
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218581069
cc @yhuai @cloud-fan @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218575667
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218575662
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218575357
**[Test build #58393 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58393/consoleFull)**
for PR 13045 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218548936
**[Test build #58393 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58393/consoleFull)**
for PR 13045 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218446255
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218446257
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218446117
**[Test build #58365 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58365/consoleFull)**
for PR 13045 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218429665
**[Test build #58365 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58365/consoleFull)**
for PR 13045 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218424994
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218424992
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218424765
**[Test build #58357 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58357/consoleFull)**
for PR 13045 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218406705
**[Test build #58357 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58357/consoleFull)**
for PR 13045 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218381999
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218381997
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218381873
**[Test build #58334 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58334/consoleFull)**
for PR 13045 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13045#issuecomment-218370929
**[Test build #58334 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58334/consoleFull)**
for PR 13045 at commit
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/13045
[SPARK-15114][SQL] Column name generated by typed aggregate is super verbose
## What changes were proposed in this pull request?
Generate a shorter default alias for
79 matches
Mail list logo
