Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/13228#discussion_r64345475
--- Diff: python/pyspark/ml/feature.py ---
@@ -1250,6 +1257,20 @@ def getNumBuckets(self):
"""
return
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13228
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13228#discussion_r64344703
--- Diff: python/pyspark/ml/feature.py ---
@@ -1250,6 +1257,20 @@ def getNumBuckets(self):
"""
return
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13228#issuecomment-221192896
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13228#issuecomment-221192898
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13228#issuecomment-221192784
**[Test build #59188 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59188/consoleFull)**
for PR 13228 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13228#issuecomment-221185187
**[Test build #59188 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59188/consoleFull)**
for PR 13228 at commit
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/13228#issuecomment-221184857
jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/13228#discussion_r64270058
--- Diff: python/pyspark/ml/feature.py ---
@@ -1250,6 +1257,20 @@ def getNumBuckets(self):
"""
return
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/13228#issuecomment-221062894
@jkbradley fair enough - I misinterpreted things thinking we were trying to
nail down further Python parity. I do agree the focus should be on docs / QA.
As it happens
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/13228#issuecomment-221037153
Just reviewed, and this LGTM : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/13228#issuecomment-221035663
I do want us to push for pyspark parity as much as possible, but I made
those QA JIRAs for Python parity checks to do an audit, not to achieve parity
for 2.0. I
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/13228#issuecomment-220759647
@jkbradley this is a missing param on the python side - I noticed it while
reviewing the PR for doc for count vectorizer, hashing tf and quantile
discretizer.
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/13228#issuecomment-220734278
Is this targeted at 2.0? I'd prefer we focus on finishing documentation &
QA checks before working on new features and APIs.
---
If your project is set up for it,
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/13228#issuecomment-220729967
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/13228#discussion_r64113992
--- Diff: python/pyspark/ml/feature.py ---
@@ -1250,6 +1257,20 @@ def getNumBuckets(self):
"""
return
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13228#issuecomment-220714826
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13228#issuecomment-220714827
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13228#issuecomment-220714687
**[Test build #59021 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59021/consoleFull)**
for PR 13228 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13228#issuecomment-220705009
**[Test build #59021 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59021/consoleFull)**
for PR 13228 at commit
GitHub user MLnick opened a pull request:
https://github.com/apache/spark/pull/13228
[SPARK-15442][ML][PYSPARK] Add 'relativeError' param to PySpark
QuantileDiscretizer
This PR adds the `relativeError` param to PySpark's `QuantileDiscretizer`
to match Scala.
Also cleaned
21 matches
Mail list logo
