[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-11 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/990#discussion_r13635448 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ConstantFoldingSuite.scala --- @@ -173,4 +173,63 @@ class ConstantFoldingSuite

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45706927 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45706938 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-11 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45785433 Hey, this isn't mergable anymore. Mind rebasing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45813703 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45813714 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45818717 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15693/ --- If your project

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45818716 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/990 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-11 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45819003 Thanks! Merged into master and 1.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45582226 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-10 Thread ueshin
Github user ueshin commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45582389 @marmbrus I checked and remove the unneeded rules from `NullPropagation`. Could you please check the changes? --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45583299 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15606/ --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45583276 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45583298 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45569478 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-09 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/990#discussion_r13576056 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -154,6 +155,10 @@ object NullPropagation extends

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-09 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/990#discussion_r13576069 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -154,6 +155,10 @@ object NullPropagation extends

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-09 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/990#discussion_r13576722 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -154,6 +155,10 @@ object NullPropagation extends

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-09 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/990#discussion_r13577271 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -154,6 +155,10 @@ object NullPropagation extends

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45574334 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45574335 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45574336 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15597/ --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-09 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/990#discussion_r13530167 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -288,3 +293,18 @@ object SimplifyCasts extends

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/990#discussion_r13530208 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -288,3 +293,18 @@ object SimplifyCasts extends

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-09 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/990#discussion_r13530241 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -288,3 +293,18 @@ object SimplifyCasts extends

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45463867 This looks good to me. Can you add some unit tests for collapsing case statements? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-09 Thread ueshin
Github user ueshin commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45465573 Thank you for your comments. I added some tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45465776 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45469127 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45473517 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15561/ --- If your project

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45473514 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-09 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/990#discussion_r13558814 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -154,6 +155,10 @@ object NullPropagation extends

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-08 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/990#discussion_r13529691 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -288,3 +293,18 @@ object SimplifyCasts extends

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45308169 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45308172 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15495/ --- If your project

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45303026 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-05 Thread ueshin
GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/990 [SPARK-2052] [SQL] Add optimization for CaseConversionExpression's. Add optimization for `CaseConversionExpression`'s. You can merge this pull request into a Git repository by running: $ git

[GitHub] spark pull request: [SPARK-2052] [SQL] Add optimization for CaseCo...

2014-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/990#issuecomment-45304700 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have