Github user hellertime commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-74944182
@tnachen That Dockerfile you have is actually all that is needed for an
example image; that its based on the mesosphere image is even better!
I had hoped that
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-74939602
[Test build #27688 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27688/consoleFull)
for PR 3074 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-74939621
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user hellertime commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-74937819
So perhaps putting an example Dockerfile in the `docker` subdirectory is
not an appropriate thing to do... any suggestions on a better location for
examples such as
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-74939617
[Test build #27688 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27688/consoleFull)
for PR 3074 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-74692249
[Test build #27632 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27632/consoleFull)
for PR 3074 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-74702659
[Test build #27634 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27634/consoleFull)
for PR 3074 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-74699492
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user hellertime commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-74700554
Missed that EasyMock is not longer the mocking kit. Gotta fixup my tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-74699476
[Test build #27632 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27632/consoleFull)
for PR 3074 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-74686697
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-74686687
[Test build #27630 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27630/consoleFull)
for PR 3074 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-74680089
[Test build #27630 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27630/consoleFull)
for PR 3074 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-74718706
[Test build #27634 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27634/consoleFull)
for PR 3074 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-74718716
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3074#discussion_r24427319
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -226,9 +226,21 @@ private[spark] class
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3074#discussion_r24427450
--- Diff: pom.xml ---
@@ -115,7 +115,7 @@
java.version1.6/java.version
sbt.project.namespark/sbt.project.name
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-73734321
@hellertime Are you going to update this patch and also include a
Dockerfile?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user hellertime commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-73810490
I'm on a short vacation this week so I'll not be making changes until I
return. That dropped version is just a merge error I didn't catch. I'm planning
to address the
Github user hellertime commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-73107870
Still working to integrate the new docker examples, but I've fixed up the
code
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-73108042
[Test build #26854 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26854/consoleFull)
for PR 3074 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-73150486
[Test build #26864 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26864/consoleFull)
for PR 3074 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-73154931
[Test build #26864 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26864/consoleFull)
for PR 3074 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-73154937
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-73117420
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-73117407
[Test build #26854 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26854/consoleFull)
for PR 3074 at commit
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-72533820
@hellertime Here are some examples:
```
time sbt/sbt -Pyarn -Phadoop-2.3 -Dhadoop.version=2.3.0 -Pkinesis-asl
-Phive -Phive-thriftserver catalyst/test
Github user hellertime commented on a diff in the pull request:
https://github.com/apache/spark/pull/3074#discussion_r23931789
--- Diff: conf/docker.properties.template ---
@@ -0,0 +1,3 @@
+spark.executor.docker.image: amplab/spark-1.1.0
--- End diff --
I think
Github user hellertime commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-72477463
BTW. This is a meta question, but how do you run a single spark test suite?
I've tried both the maven-surefire method of
`-Dtest=MesosSchedulerBackendSuite` and the
Github user tarnfeld commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-71638383
Providing a basic Dockerfile is a great idea, it'll at least get people
going. Though it really is as simple as installing spark and setting the
`SPARK_HOME`
Github user huitseeker commented on a diff in the pull request:
https://github.com/apache/spark/pull/3074#discussion_r23604904
--- Diff: conf/docker.properties.template ---
@@ -0,0 +1,3 @@
+spark.executor.docker.image: amplab/spark-1.1.0
--- End diff --
Should this
Github user hellertime commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-71454692
@andrewor14 your suggestions all look quite reasonable, I'll have a closer
look at them tonight and make appropriate changes.
@mateiz adding a Dockerfile will
Github user rdhyee commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-71475481
I [wrote in November of my interest in this
PR](https://github.com/apache/spark/pull/3074#issuecomment-64227322). I concur
the
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-71487679
Yeah, so IMO just provide a basic Dockerfile that lets people but in their
compiled build of Spark, and we can go from there. They should also have the
option of
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-71414280
Just curious, on the Docker image, who provides that? I'd only merge this
if it comes with a Dockerfile to let users build their own image. We can't rely
on one hosted
Github user rbraley commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-71417301
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3074#discussion_r23509285
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -225,9 +225,22 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3074#discussion_r23509291
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -225,9 +225,22 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3074#discussion_r23509311
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -225,9 +225,22 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3074#discussion_r23509317
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -225,9 +225,22 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3074#discussion_r23509302
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -225,9 +225,22 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3074#discussion_r23509288
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -225,9 +225,22 @@ private[spark] class
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-71402227
Hi @hellertime @tnachen sorry for the wait. This feature definitely looks
like something that would be good to support. However, admittedly I do not have
sufficient
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3074#discussion_r23509344
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3074#discussion_r23509338
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3074#discussion_r23509328
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-71408279
Hi @andrewor14, I am not sure if there is a more suitable committer as well.
To me I think the change looks good function wise and have already been
tested. IMO
Github user tarnfeld commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-71040782
I've got a branch based on the current spark master that cherry-picks (and
fixes conflicts) these changes. I'm in the process of testing it now, and will
open a
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-70712262
@andrewor14 can you take a look at this patch? I'm hoping to get this in
soon as it's been sitting for 2+ months now.
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-69232489
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-69232479
[Test build #25246 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25246/consoleFull)
for PR 3074 at commit
Github user hellertime commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-69233810
I've rebased to master, could someone retest this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-69244625
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-69244619
[Test build #25252 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25252/consoleFull)
for PR 3074 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-69234126
[Test build #25252 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25252/consoleFull)
for PR 3074 at commit
101 - 155 of 155 matches
Mail list logo
