Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-60714744
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-60714742
[Test build #22337 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22337/consoleFull)
for PR 2570 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-60835836
Thanks for working on this! I'm going to merge it in, but we should
consider moving the semantic analyzer part to the analysis phase. These
execution APIs are all
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2570
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-60560204
[Test build #22283 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22283/consoleFull)
for PR 2570 at commit
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-60560261
@marmbrus, I've rebase dthe code with latest master (with Hive 0.13.1
supported, but not compatible with Hive 0.12). Please let me know if you have
concerns on
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-60560430
[Test build #22283 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22283/consoleFull)
for PR 2570 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-60560431
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-60562071
Build failed because this PR is only compatible with Hive 0,13.1 (not 0.12
any more).
---
If your project is set up for it, you can reply to this email and have
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-60590668
Can you explain the reason that hive 0.12 is not supported?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-60696885
[Test build #22317 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22317/consoleFull)
for PR 2570 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-60697467
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-60697462
[Test build #22317 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22317/consoleFull)
for PR 2570 at commit
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-60698604
@yhuai Some of the methods signature changed after upgrading to Hive 0.13,
this actually is my concerns for how to write the shim code.
For this case:
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-60699948
Is it possible to add a method in shim like the following one?
```
// Hive 0.13
def setTableDataLocation(table: Table, createTableDesc: CreateTableDesc) {
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-60702583
Support conditional compilation probably need some workaround here, that's
a general problem for the Hive upgrading I think. We need another PR to solve
that
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-60705802
@chenghao-intel there is already support for conditional compilation based
on hive version. This code can go in
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-60710618
Thanks @marmbrus I will update the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-60711633
[Test build #22337 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22337/consoleFull)
for PR 2570 at commit
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2570#discussion_r19384148
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -160,17 +162,14 @@ private[hive] trait HiveStrategies {
def
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2570#discussion_r19384160
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateTableAsSelect.scala
---
@@ -30,33 +32,46 @@ import
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-60534526
This would be a great feature to get in before 1.2. I made a few minor
comments. Also, can you rebase?
---
If your project is set up for it, you can reply to this
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2570#discussion_r19386385
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -160,17 +162,14 @@ private[hive] trait HiveStrategies {
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2570#discussion_r19386522
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateTableAsSelect.scala
---
@@ -30,33 +32,46 @@ import
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2570#discussion_r19386550
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateTableAsSelect.scala
---
@@ -30,33 +32,46 @@ import
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-60475354
[Test build #444 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/444/consoleFull)
for PR 2570 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-60477038
[Test build #444 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/444/consoleFull)
for PR 2570 at commit
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-60178363
@marmbrus , sorry I know you're super busy recently, can you give more
comments on this?
---
If your project is set up for it, you can reply to this email and
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-59049695
@marmbrus any more comment on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-58739817
test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-58739815
Seems the failure is not related to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-58739903
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21635/consoleFull)
for PR 2570 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-58740765
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-58740758
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21635/consoleFull)
for PR 2570 at commit
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2570#discussion_r18690123
--- Diff:
sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
---
@@ -211,7 +211,11 @@ class
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2570#discussion_r18692067
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -117,8 +117,10 @@ case class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-58625852
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21586/consoleFull)
for PR 2570 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-58626811
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21587/consoleFull)
for PR 2570 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-58628891
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-58628884
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21586/consoleFull)
for PR 2570 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-58630045
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21587/consoleFull)
for PR 2570 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-58630054
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-58329046
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21458/consoleFull)
for PR 2570 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-58334350
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-58334343
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21458/consoleFull)
for PR 2570 at commit
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-58451206
I've updated the code, @yhuai @marmbrus , any more comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-58451631
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-58454245
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21509/consoleFull)
for PR 2570 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-58456682
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-58456679
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21509/consoleFull)
for PR 2570 at commit
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2570#discussion_r18561069
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateTableAsSelect.scala
---
@@ -30,25 +32,38 @@ import
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2570#discussion_r18561142
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateTableAsSelect.scala
---
@@ -56,7 +71,10 @@ case class
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2570#discussion_r18561343
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -492,14 +492,9 @@ private[hive] object HiveQl {
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-58296226
Thank you @yhuai , I will update the code accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2570#discussion_r18263442
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -32,6 +32,54 @@ case class Nested3(f3: Int)
*
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2570#discussion_r18263559
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateTableAsSelect.scala
---
@@ -30,25 +32,38 @@ import
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-57432988
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-57461439
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-57462077
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21112/consoleFull)
for PR 2570 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/2570#discussion_r18279773
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateTableAsSelect.scala
---
@@ -56,7 +71,10 @@ case class CreateTableAsSelect(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-57470303
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-57470296
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21112/consoleFull)
for PR 2570 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/2570#discussion_r18280936
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateTableAsSelect.scala
---
@@ -30,25 +32,38 @@ import
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/2570#discussion_r18281051
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -70,6 +77,153 @@ private[hive] class HiveMetastoreCatalog(hive:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/2570#discussion_r18281532
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -70,6 +77,153 @@ private[hive] class HiveMetastoreCatalog(hive:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/2570#discussion_r18281667
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -492,14 +492,9 @@ private[hive] object HiveQl {
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/2570#discussion_r18242621
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -32,6 +32,54 @@ case class Nested3(f3: Int)
* valid,
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/2570#discussion_r18243382
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateTableAsSelect.scala
---
@@ -30,25 +32,38 @@ import
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-57261085
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21016/consoleFull)
for PR 2570 at commit
GitHub user chenghao-intel opened a pull request:
https://github.com/apache/spark/pull/2570
[SPARK-3343] [SQL] Add serde support for CTAS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chenghao-intel/spark ctas_serde
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-57112668
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20956/consoleFull)
for PR 2570 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-57115003
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20956/consoleFull)
for PR 2570 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2570#issuecomment-57115005
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
73 matches
Mail list logo
