GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/11637
[SPARK-3854] Scala style: require spaces before `{`.
## What changes were proposed in this pull request?
Since the opening curly brace, '{', has many usages as discussed in
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58849280
Hi @sarutak,
We'd like to avoid making large refactorings for style, since these changes
tend to create merge-conflicts when backporting to maintenance
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58852435
O.K. I close this PR for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sarutak closed the pull request at:
https://github.com/apache/spark/pull/2761
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58776141
I also think, it's difficult to apply new style checker only to new codes.
I cleaned up codes in origin/master for the style checker suggested in this PR.
So, if this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58801175
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21670/consoleFull)
for PR 2761 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58805927
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21670/consoleFull)
for PR 2761 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58805931
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58739434
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58739441
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21632/consoleFull)
for PR 2761 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58739472
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21632/consoleFull)
for PR 2761 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58739473
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58739516
Oh, I didn't run scalastyle for yarn-alpha.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58739525
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21633/consoleFull)
for PR 2761 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58739546
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58739545
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21633/consoleFull)
for PR 2761 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58739709
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21634/consoleFull)
for PR 2761 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58739778
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58739777
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21634/consoleFull)
for PR 2761 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58740083
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21636/consoleFull)
for PR 2761 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58741924
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21636/consoleFull)
for PR 2761 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58741926
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58742157
I quite like standardizing style, but doesn't this have the same problem
mentioned before, that it's going to break a lot of potential merge commits? If
it's
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58759963
It would be neat if there was some way to restrict the style checker to
only check new/changed lines introduced by a PR. This could be hard to
integrate with local
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58769389
I quite like standardizing style, but doesn't this have the same problem
mentioned before, that it's going to break a lot of potential merge commits?
When I
GitHub user sarutak opened a pull request:
https://github.com/apache/spark/pull/2761
[SPARK-3854] Scala style: require spaces before `{`
This PR is a solution proposal of SPARK-3854.
Following is quoted from SPARK-3854:
We should require spaces before opening curly
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58739200
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58739375
Jenkins, add to whitelist. This is ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58739394
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
29 matches
Mail list logo
