[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10129 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-15 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10129#issuecomment-164967032 Merging into master, thanks @devaraj-kavali. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-15 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10129#issuecomment-164899158 > sorry I hadn't gotten back to this. yes if its fatal we should exit immediately or if we reached the max retries. That is still handled by the else if. Oh

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-15 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/10129#issuecomment-164774749 @andrewor14 sorry I hadn't gotten back to this. yes if its fatal we should exit immediately or if we reached the max retries. That is still handled by the else if.

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-15 Thread devaraj-kavali
Github user devaraj-kavali commented on a diff in the pull request: https://github.com/apache/spark/pull/10129#discussion_r47625366 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -372,7 +372,14 @@ private[spark] class ApplicationMaster(

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-15 Thread 3ourroom
Github user 3ourroom commented on the pull request: https://github.com/apache/spark/pull/10129#issuecomment-164734411 NAVER - http://www.naver.com/ 3ourr...@naver.com 님께 보내신 메일 이 다음과 같은 이유로

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-15 Thread devaraj-kavali
Github user devaraj-kavali commented on the pull request: https://github.com/apache/spark/pull/10129#issuecomment-164734226 Thanks @andrewor14 for the review and comments. I have updated them, can you have look into it. --- If your project is set up for it, you can reply to this emai

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10129#discussion_r47576221 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -372,7 +372,14 @@ private[spark] class ApplicationMaster(

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10129#discussion_r47576063 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -372,7 +372,14 @@ private[spark] class ApplicationMaster(

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10129#discussion_r47576092 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -372,7 +372,14 @@ private[spark] class ApplicationMaster(

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10129#discussion_r47576032 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -372,7 +372,14 @@ private[spark] class ApplicationMaster(

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10129#discussion_r47575952 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -372,7 +372,14 @@ private[spark] class ApplicationMaster(

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-08 Thread devaraj-kavali
Github user devaraj-kavali commented on the pull request: https://github.com/apache/spark/pull/10129#issuecomment-162880724 @tgravescs I have made the changes, Please have a look into this. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-04 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/10129#issuecomment-162029242 I'm not overly concerned with hadoop < 2.4 version since they changed the api, so I say we just leave that unhandled until someone specifically requests it.

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-04 Thread devaraj-kavali
Github user devaraj-kavali commented on the pull request: https://github.com/apache/spark/pull/10129#issuecomment-162022777 Thanks @tgravescs for the details. I missed it before creating PR. I am thinking these ways for supporting <2.4 Apache Hadoop versions and as well as for

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-03 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/10129#issuecomment-161655139 the compilation failed on hadoop 2.3 because It looks like ApplicationAttemptNotFoundException was introduced in hadoop 2.4. We need to support back to hadoop 2.2.

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10129#issuecomment-161653316 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10129#issuecomment-161653319 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10129#issuecomment-161653306 **[Test build #47140 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47140/consoleFull)** for PR 10129 at commit [`636fd78`](https://g

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10129#issuecomment-161650565 **[Test build #47140 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47140/consoleFull)** for PR 10129 at commit [`636fd78`](https://gi

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-03 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/10129#issuecomment-161645671 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-03 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/10129#discussion_r46546311 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -370,6 +371,12 @@ private[spark] class ApplicationMaster(

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10129#issuecomment-161585597 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-03 Thread devaraj-kavali
GitHub user devaraj-kavali opened a pull request: https://github.com/apache/spark/pull/10129 [SPARK-4117] [YARN] Spark on Yarn handle AM being told command from RM Spark on Yarn handle AM being told command from RM When RM throws ApplicationAttemptNotFoundException for alloc