Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3341#issuecomment-63939012
LGTM too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/3341#issuecomment-63939765
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3341#issuecomment-63940666
Ok merging this in master and branch-1.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zsxwing closed the pull request at:
https://github.com/apache/spark/pull/3341
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/3341#discussion_r20563523
--- Diff:
repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -61,11 +61,14 @@ class SparkILoop(in0: Option[BufferedReader], protected
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3341#discussion_r20564271
--- Diff:
repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -61,11 +61,14 @@ class SparkILoop(in0: Option[BufferedReader],
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3341#discussion_r20564330
--- Diff:
repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -61,11 +61,14 @@ class SparkILoop(in0: Option[BufferedReader],
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/3341#discussion_r20564849
--- Diff:
repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -61,11 +61,14 @@ class SparkILoop(in0: Option[BufferedReader], protected
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/3341#issuecomment-63740086
Seems like a good idea. @ScrapCodes does this look okay to you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3341#issuecomment-63447084
[Test build #23544 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23544/consoleFull)
for PR 3341 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3341#issuecomment-63456504
[Test build #23544 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23544/consoleFull)
for PR 3341 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3341#issuecomment-63456512
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/3341#discussion_r20523279
--- Diff:
repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -61,11 +61,14 @@ class SparkILoop(in0: Option[BufferedReader], protected
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3341#discussion_r20552952
--- Diff:
repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -61,11 +61,14 @@ class SparkILoop(in0: Option[BufferedReader],
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/3341#discussion_r20557393
--- Diff:
repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -61,11 +61,14 @@ class SparkILoop(in0: Option[BufferedReader], protected
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3341#discussion_r20558172
--- Diff:
repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -61,11 +61,14 @@ class SparkILoop(in0: Option[BufferedReader],
16 matches
Mail list logo
