[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-29 Thread dragos
Github user dragos commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-72061693 See #4270 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-28 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-71854715 @dragos good catch. It sounds like an issue with the test if anything. You could just reopen SPARK-4631 with a workaround. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-28 Thread dragos
Github user dragos commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-71858250 @srowen I commented on the ticket, but I can't re-open it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-28 Thread dragos
Github user dragos commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-71852913 There also seems to be a race condition introduced by this test. It fails consistently for me (but passes if I add a `Thread.sleep(50)` inside `publishData`). I'll open a

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-12 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-69675455 It looks like there's maybe a port-binding / racing issue here?

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-12 Thread Bilna
Github user Bilna commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-69694551 ok.. I will look into it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-05 Thread Bilna
Github user Bilna commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68686800 @tdas, Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-05 Thread Bilna
Github user Bilna commented on a diff in the pull request: https://github.com/apache/spark/pull/3844#discussion_r22453522 --- Diff: external/mqtt/src/test/scala/org/apache/spark/streaming/mqtt/MQTTStreamSuite.scala --- @@ -17,31 +17,111 @@ package

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-05 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/3844#discussion_r22459212 --- Diff: external/mqtt/src/test/scala/org/apache/spark/streaming/mqtt/MQTTStreamSuite.scala --- @@ -17,31 +17,111 @@ package

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-05 Thread Bilna
Github user Bilna commented on a diff in the pull request: https://github.com/apache/spark/pull/3844#discussion_r22507984 --- Diff: external/mqtt/src/test/scala/org/apache/spark/streaming/mqtt/MQTTStreamSuite.scala --- @@ -17,31 +17,111 @@ package

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68646513 [Test build #25035 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25035/consoleFull) for PR 3844 at commit

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68646517 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-04 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/3844#discussion_r22446708 --- Diff: external/mqtt/src/test/scala/org/apache/spark/streaming/mqtt/MQTTStreamSuite.scala --- @@ -17,31 +17,111 @@ package

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-04 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68665022 Merging this, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3844 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68589126 [Test build #25007 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25007/consoleFull) for PR 3844 at commit

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68589130 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68587233 [Test build #25007 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25007/consoleFull) for PR 3844 at commit

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-03 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/3844#discussion_r22435908 --- Diff: external/mqtt/pom.xml --- @@ -47,6 +47,11 @@ version1.0.1/version /dependency dependency +

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-03 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68616859 Only one more comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-02 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/3844#discussion_r22429050 --- Diff: external/mqtt/src/test/scala/org/apache/spark/streaming/mqtt/MQTTStreamSuite.scala --- @@ -17,31 +17,114 @@ package

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-02 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68581068 This is almost looking good. few more comments and we are ready. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68525514 [Test build #24994 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24994/consoleFull) for PR 3844 at commit

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68525516 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68525682 [Test build #24996 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24996/consoleFull) for PR 3844 at commit

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68525686 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-02 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/3844#discussion_r22427641 --- Diff: external/mqtt/src/test/scala/org/apache/spark/streaming/mqtt/MQTTStreamSuite.scala --- @@ -17,31 +17,114 @@ package

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-02 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/3844#discussion_r22427589 --- Diff: external/mqtt/src/test/scala/org/apache/spark/streaming/mqtt/MQTTStreamSuite.scala --- @@ -17,31 +17,114 @@ package

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-02 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/3844#discussion_r22427587 --- Diff: external/mqtt/src/test/scala/org/apache/spark/streaming/mqtt/MQTTStreamSuite.scala --- @@ -17,31 +17,114 @@ package

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-02 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/3844#discussion_r22427535 --- Diff: external/mqtt/pom.xml --- @@ -16,65 +16,71 @@ ~ limitations under the License. -- --- End diff -- This file should not

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2015-01-01 Thread Bilna
Github user Bilna commented on a diff in the pull request: https://github.com/apache/spark/pull/3844#discussion_r22405599 --- Diff: external/mqtt/src/test/scala/org/apache/spark/streaming/mqtt/MQTTStreamSuite.scala --- @@ -17,31 +17,65 @@ package

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68428985 [Test build #24948 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24948/consoleFull) for PR 3844 at commit

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68428989 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68429312 [Test build #24949 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24949/consoleFull) for PR 3844 at commit

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68429316 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68433088 [Test build #24956 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24956/consoleFull) for PR 3844 at commit

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68435869 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68435866 [Test build #24956 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24956/consoleFull) for PR 3844 at commit

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/3844#discussion_r22397269 --- Diff: external/mqtt/src/test/scala/org/apache/spark/streaming/mqtt/MQTTStreamSuite.scala --- @@ -17,31 +17,65 @@ package

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/3844#discussion_r22397277 --- Diff: external/mqtt/src/test/scala/org/apache/spark/streaming/mqtt/MQTTStreamSuite.scala --- @@ -17,31 +17,65 @@ package

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-30 Thread Bilna
GitHub user Bilna opened a pull request: https://github.com/apache/spark/pull/3844 [SPARK-4631] unit test for MQTT You can merge this pull request into a Git repository by running: $ git pull https://github.com/Bilna/spark master Alternatively you can review and apply these

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68355440 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-30 Thread prabeesh
Github user prabeesh commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68355645 @tdas verify this patch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-30 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68417426 Jenksin, this is ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68417591 [Test build #24922 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24922/consoleFull) for PR 3844 at commit

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-30 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/3844#discussion_r22372726 --- Diff: external/mqtt/src/test/scala/org/apache/spark/streaming/mqtt/MQTTStreamSuite.scala --- @@ -17,31 +17,58 @@ package

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-30 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/3844#discussion_r22372739 --- Diff: external/mqtt/src/test/scala/org/apache/spark/streaming/mqtt/MQTTStreamSuite.scala --- @@ -17,31 +17,58 @@ package

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68419761 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68419759 [Test build #24922 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24922/consoleFull) for PR 3844 at commit

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68426613 [Test build #24946 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24946/consoleFull) for PR 3844 at commit

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68427068 [Test build #24948 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24948/consoleFull) for PR 3844 at commit

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68427356 [Test build #24949 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24949/consoleFull) for PR 3844 at commit

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68428438 [Test build #24946 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24946/consoleFull) for PR 3844 at commit

[GitHub] spark pull request: [SPARK-4631] unit test for MQTT

2014-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3844#issuecomment-68428440 Test FAILed. Refer to this link for build results (access rights to CI server needed):