[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-20 Thread marmbrus
Github user marmbrus closed the pull request at: https://github.com/apache/spark/pull/3752 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-20 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/3752#issuecomment-70783358 Let's close it since #3960 has been merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-13 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/3960#discussion_r22916186 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -310,4 +311,17 @@ private[sql] abstract class SparkStrategies

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-13 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/3960#discussion_r22917623 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -310,4 +311,17 @@ private[sql] abstract class SparkStrategies

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-13 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/3960#discussion_r22918651 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -310,4 +311,17 @@ private[sql] abstract class SparkStrategies

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69807900 [Test build #25482 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25482/consoleFull) for PR 3960 at commit

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-13 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/3960#discussion_r22893043 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -50,8 +52,76 @@ private[hive] class HiveMetastoreCatalog(hive:

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-13 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69816529 LGTM once tests pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3960 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-13 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/3960#discussion_r22892556 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -310,4 +311,17 @@ private[sql] abstract class SparkStrategies

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-13 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/3960#discussion_r22892993 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -50,8 +52,76 @@ private[hive] class HiveMetastoreCatalog(hive:

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69818876 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/3960#discussion_r22820260 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/3960#discussion_r22820211 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/commands.scala --- @@ -52,6 +53,10 @@ case class DropTable( override def

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69645325 [Test build #25429 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25429/consoleFull) for PR 3960 at commit

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/3960#discussion_r22820146 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -50,8 +52,75 @@ private[hive] class HiveMetastoreCatalog(hive:

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/3960#discussion_r22820049 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -50,8 +52,75 @@ private[hive] class HiveMetastoreCatalog(hive:

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69656617 [Test build #25429 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25429/consoleFull) for PR 3960 at commit

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69656621 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/3960#discussion_r22834708 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala --- @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69676512 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69676506 [Test build #25435 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25435/consoleFull) for PR 3960 at commit

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69680966 [Test build #25438 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25438/consoleFull) for PR 3960 at commit

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69680968 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69669594 [Test build #25435 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25435/consoleFull) for PR 3960 at commit

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69676051 [Test build #25438 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25438/consoleFull) for PR 3960 at commit

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69695067 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69695330 [Test build #25456 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25456/consoleFull) for PR 3960 at commit

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69699358 [Test build #25456 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25456/consoleFull) for PR 3960 at commit

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69699363 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69523998 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69523995 [Test build #25387 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25387/consoleFull) for PR 3960 at commit

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69521322 [Test build #25387 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25387/consoleFull) for PR 3960 at commit

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2015-01-05 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/3752#discussion_r22507568 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -55,8 +56,61 @@ private[hive] class HiveMetastoreCatalog(hive:

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2014-12-22 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/3752#discussion_r22159720 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -55,8 +56,60 @@ private[hive] class

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2014-12-22 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/3752#discussion_r22160548 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -55,8 +56,60 @@ private[hive] class

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2014-12-22 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/3752#discussion_r22161200 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -55,8 +56,60 @@ private[hive] class

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2014-12-22 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/3752#discussion_r22183385 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -55,8 +56,60 @@ private[hive] class HiveMetastoreCatalog(hive:

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2014-12-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3752#issuecomment-67876256 [Test build #24707 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24707/consoleFull) for PR 3752 at commit

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2014-12-22 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/3752#discussion_r22183673 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -55,8 +56,60 @@ private[hive] class HiveMetastoreCatalog(hive:

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2014-12-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3752#issuecomment-67876806 [Test build #24708 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24708/consoleFull) for PR 3752 at commit

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2014-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3752#issuecomment-67884470 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2014-12-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3752#issuecomment-67884465 [Test build #24707 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24707/consoleFull) for PR 3752 at commit

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2014-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3752#issuecomment-67884755 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2014-12-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3752#issuecomment-67884749 [Test build #24708 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24708/consoleFull) for PR 3752 at commit

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2014-12-22 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/3752#discussion_r22204038 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -55,8 +56,60 @@ private[hive] class

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2014-12-22 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/3752#discussion_r22204044 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -55,8 +56,60 @@ private[hive] class

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2014-12-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3752#issuecomment-67787708 [Test build #24689 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24689/consoleFull) for PR 3752 at commit

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2014-12-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3752#issuecomment-67790092 [Test build #24689 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24689/consoleFull) for PR 3752 at commit

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2014-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3752#issuecomment-67790096 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2014-12-20 Thread marmbrus
GitHub user marmbrus opened a pull request: https://github.com/apache/spark/pull/3752 [SPARK-4912][SQL] Persistent tables for the Spark SQL data sources This is the first of a few improvements I'd like to make to the data sources API. I'll note that this does not correctly handle

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2014-12-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3752#issuecomment-67749769 [Test build #24677 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24677/consoleFull) for PR 3752 at commit

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2014-12-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3752#issuecomment-67750987 [Test build #24677 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24677/consoleFull) for PR 3752 at commit

[GitHub] spark pull request: [SPARK-4912][SQL] Persistent tables for the Sp...

2014-12-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3752#issuecomment-67750989 Test FAILed. Refer to this link for build results (access rights to CI server needed):