[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72808101 [Test build #26732 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26732/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72808109 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72810958 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72810950 [Test build #26733 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26733/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72808682 [Test build #577 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/577/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72822525 [Test build #577 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/577/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72812543 [Test build #578 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/578/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-04 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72920317 LGTM (but will wait to merge until @markhamstra and @JoshRosen give the thumb's up, just in case they have any remaining comments) --- If your project is set up

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-04 Thread markhamstra
Github user markhamstra commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72922174 LGTMT --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3779 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-04 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72953034 Thanks all! I've merged this into 1.3 and master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-04 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72952510 I understood the high-level idea here and was just waiting for @kayousterhout and @markhamstra to review the details, so this seems fine to me. Thanks for reviewing

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72829704 [Test build #578 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/578/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r24066157 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,59 @@ private[spark] class TaskSetManager( *

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72805131 [Test build #26733 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26733/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r24065322 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,59 @@ private[spark] class TaskSetManager( *

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r24065269 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,59 @@ private[spark] class TaskSetManager( *

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r24065817 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,59 @@ private[spark] class TaskSetManager( *

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r24066349 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,59 @@ private[spark] class TaskSetManager( *

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r24065900 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,59 @@ private[spark] class TaskSetManager( *

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r24065627 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,59 @@ private[spark] class TaskSetManager( * Get the

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r24066137 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,59 @@ private[spark] class TaskSetManager( *

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r24067496 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,63 @@ private[spark] class TaskSetManager( * Get the

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r24065873 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,59 @@ private[spark] class TaskSetManager( *

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r24066698 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,59 @@ private[spark] class TaskSetManager( *

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r24065502 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,59 @@ private[spark] class TaskSetManager( *

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r24066639 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,59 @@ private[spark] class TaskSetManager( * Get the

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72803247 @kayousterhout @markhamstra @JoshRosen I should had addressed all your comments, they are very helpful, thanks you all! --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72803322 [Test build #26732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26732/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r24065454 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,59 @@ private[spark] class TaskSetManager( *

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r24065965 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,59 @@ private[spark] class TaskSetManager( * Get the

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72800486 Echoing the comments from @markhamstra and @JoshRosen, this change looks correct but is very subtle, so it would be great to improve the commenting throughout to

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r24067444 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,63 @@ private[spark] class TaskSetManager( * Get the

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r24066617 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,59 @@ private[spark] class TaskSetManager( * Get the

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r24067073 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,63 @@ private[spark] class TaskSetManager( *

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r24048516 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,59 @@ private[spark] class TaskSetManager( *

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-03 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r24049293 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,59 @@ private[spark] class TaskSetManager( *

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72586368 If we have tasks at some high locality level that cannot be scheduled at their preferred locality and there are tasks at a lower locality level that can be scheduled,

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-02 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72598196 For any resource, it will try from the highest locality. TaskSetManager checks the current lowest locality level's wait is non-zero to determine the allowed lowest

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r23981098 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,59 @@ private[spark] class TaskSetManager( * Get

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r23981053 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,59 @@ private[spark] class TaskSetManager( * Get

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-02 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r23984210 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -506,13 +506,59 @@ private[spark] class TaskSetManager( * Get the

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72597256 I took a pass through this, but I'll admit that I'm a little out of my depth w.r.t. scheduler internals here. I think that I understand the goals / invariants of the

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72597115 [Test build #26612 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26612/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-02 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72599896 cc scheduler czars also... @kayousterhout @markhamstra --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72604521 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72604515 [Test build #26612 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26612/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-02-02 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72584682 _(Stream-of-consciousness ahead, mostly for my own benefit as I think through the implications of this PR)_ I'd like to understand whether this patch has any

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-29 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-72116552 @pwendell As pointed out in #4147 , the fix in LocalBackend still have several seconds delay in each stage, it still hurt Spark Streaming. Or should we set

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-26 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-71553313 @tdas I noted on the JIRA, but since there is collateral effects of this change beyond local mode I think we decided not to put it in 1.2.1. --- If your project is set

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-22 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-71000700 @kayousterhout @davies @pwendell can this be merged for 1.2.1? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-21 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r23336266 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala --- @@ -313,7 +313,8 @@ class TaskSetManagerSuite extends FunSuite with

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-21 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r23335344 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -495,13 +495,39 @@ private[spark] class TaskSetManager( * Get the

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-21 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r23339119 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -495,13 +495,39 @@ private[spark] class TaskSetManager( * Get the

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-21 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r23332736 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -495,13 +495,39 @@ private[spark] class TaskSetManager( *

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-21 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r23332765 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala --- @@ -313,7 +313,8 @@ class TaskSetManagerSuite extends FunSuite

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-21 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r23338266 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -495,13 +495,39 @@ private[spark] class TaskSetManager( *

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-21 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r23338809 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -495,13 +495,39 @@ private[spark] class TaskSetManager( * Get the

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70932412 [Test build #25918 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25918/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70947373 [Test build #25931 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25931/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70940007 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70939996 [Test build #25918 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25918/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70955949 [Test build #25931 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25931/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70955957 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70702131 [Test build #566 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/566/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70714339 [Test build #566 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/566/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70574384 [Test build #25773 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25773/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-19 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70575997 Is this definitely still an issue with LocalBackend? It seems like LocalBackend should only ever have PROCESS_LOCAL and NODE_LOCAL tasks. If it only has

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70575987 [Test build #25774 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25774/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-19 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70575375 @kayousterhout I had updated this PR to support all locality levels. The timeout of locality depends on that the scheduler backend revive offers periodically, so

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70586165 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-19 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70582394 @kayousterhout I had added a test case with PROCESS_LOCAL and NO_PREF, it seems that LocalBackend can work well, because the TaskSchedulerImpl will try multiple locality

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70586162 **[Test build #25773 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25773/consoleFull)** for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70587346 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70587342 [Test build #25778 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25778/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70582124 [Test build #25778 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25778/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70587474 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70587469 **[Test build #25774 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25774/consoleFull)** for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-16 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70348560 Why not just periodically revive offers, as we do in the cluster scheduler (see the 3 lines here:

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-16 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70349488 Revive offers periodically can fix the bug, but introduce 1 second delay (by default) for every job, it will be noticeable for streaming workload. I think it's a

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-16 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70349844 I thought local mode was just used for testing? I general my preference is to avoid this kind of workaround, which add complexity to the scheduler, make it

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-16 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/3779#discussion_r23121685 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala --- @@ -635,6 +635,28 @@ class TaskSetManagerSuite extends FunSuite

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-16 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70350611 Actually I have a slightly different question: should we be doing the same thing for other locality levels? --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-15 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-70149578 @kayousterhout Could you take a look at this. This is priority for 1.3 :) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2015-01-12 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-69666241 @pwendell Can you please take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2014-12-30 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-68387582 @pwendell I had added a regression test that fails in the old code, and added comments for them. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2014-12-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-68387930 [Test build #24903 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24903/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2014-12-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-68396667 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2014-12-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-68396660 [Test build #24903 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24903/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2014-12-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-68314408 [Test build #24870 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24870/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2014-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-68318551 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2014-12-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-68318545 [Test build #24870 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24870/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2014-12-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-68319961 [Test build #556 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/556/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2014-12-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-68324255 [Test build #556 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/556/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2014-12-25 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-68105490 @davies can you add a unit test that fails in the old code but works with your code? It would be helpful to more clearly document the exact bug. --- If your project is

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2014-12-23 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/3779 [SPARK-4939] move to next locality when no pending tasks for executors Currently, if there are different locality in a task set, the tasks with NODE_LOCAL only get scheduled after all the

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2014-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-67992975 [Test build #24746 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24746/consoleFull) for PR 3779 at commit

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2014-12-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-68000315 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4939] move to next locality when no pen...

2014-12-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3779#issuecomment-68000310 [Test build #24746 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24746/consoleFull) for PR 3779 at commit