[GitHub] spark pull request: [SPARK-5555] Enable UISeleniumSuite tests

2015-02-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4334 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-5555] Enable UISeleniumSuite tests

2015-02-06 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4334#issuecomment-73295273 I'm merging this into `master` (1.4.0) and `branch-1.3` (1.3.0). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-5555] Enable UISeleniumSuite tests

2015-02-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4334#issuecomment-73103484 [Test build #26850 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26850/consoleFull) for PR 4334 at commit

[GitHub] spark pull request: [SPARK-5555] Enable UISeleniumSuite tests

2015-02-05 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4334#discussion_r24186435 --- Diff: core/src/test/scala/org/apache/spark/ui/UISeleniumSuite.scala --- @@ -32,10 +32,8 @@ import org.apache.spark.api.java.StorageLevels import

[GitHub] spark pull request: [SPARK-5555] Enable UISeleniumSuite tests

2015-02-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4334#issuecomment-73117865 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5555] Enable UISeleniumSuite tests

2015-02-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4334#issuecomment-73117849 [Test build #26850 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26850/consoleFull) for PR 4334 at commit

[GitHub] spark pull request: [SPARK-5555] Enable UISeleniumSuite tests

2015-02-05 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/4334#issuecomment-73122659 LGTM - let's merge this and if we find it's annoying or flaky we can rip it out. Overall thought we should keep the number of these integration-style tests very low.

[GitHub] spark pull request: [SPARK-5555] Enable UISeleniumSuite tests

2015-02-04 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4334#issuecomment-72883811 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-5555] Enable UISeleniumSuite tests

2015-02-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4334#issuecomment-72884418 [Test build #26760 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26760/consoleFull) for PR 4334 at commit

[GitHub] spark pull request: [SPARK-5555] Enable UISeleniumSuite tests

2015-02-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4334#issuecomment-72899091 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5555] Enable UISeleniumSuite tests

2015-02-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4334#issuecomment-72899074 [Test build #26760 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26760/consoleFull) for PR 4334 at commit

[GitHub] spark pull request: [SPARK-5555] Enable UISeleniumSuite tests

2015-02-04 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4334#issuecomment-72956273 This entire suite adds about 10 seconds to the total test time, which doesn't seem too bad to me. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-5555] Enable UISeleniumSuite tests

2015-02-03 Thread JoshRosen
GitHub user JoshRosen opened a pull request: https://github.com/apache/spark/pull/4334 [SPARK-] Enable UISeleniumSuite tests This patch enables UISeleniumSuite, a set of tests for the Spark application web UI. These tests were previously disabled because they were slow, but I

[GitHub] spark pull request: [SPARK-5555] Enable UISeleniumSuite tests

2015-02-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4334#issuecomment-72633082 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5555] Enable UISeleniumSuite tests

2015-02-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4334#issuecomment-72633068 [Test build #26650 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26650/consoleFull) for PR 4334 at commit

[GitHub] spark pull request: [SPARK-5555] Enable UISeleniumSuite tests

2015-02-03 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4334#issuecomment-72622789 Unfortunately, these tests dump a bunch of WARN noise into `unit-tests.log`: ``` 15/02/03 01:51:04.047 pool-1-thread-1-ScalaTest-running-UISeleniumSuite

[GitHub] spark pull request: [SPARK-5555] Enable UISeleniumSuite tests

2015-02-03 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4334#issuecomment-72622985 Fortunately, nothing was broken; the test failures here were due to either legitimate changes to the UI display (such as hiding empty tables), or untested refactorings

[GitHub] spark pull request: [SPARK-5555] Enable UISeleniumSuite tests

2015-02-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4334#issuecomment-72623104 [Test build #26650 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26650/consoleFull) for PR 4334 at commit