Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/10838#discussion_r53821837
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -328,7 +345,9 @@ final class ShuffleBlockFetcherIterator(
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/spark/pull/10838#discussion_r53812741
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -328,7 +345,9 @@ final class ShuffleBlockFetcherIterator(
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/10838#discussion_r52811398
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -328,7 +345,9 @@ final class ShuffleBlockFetcherIterator(
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/10838#discussion_r52811613
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -328,7 +345,9 @@ final class ShuffleBlockFetcherIterator(
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/10838#discussion_r52811989
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -328,7 +345,9 @@ final class ShuffleBlockFetcherIterator(
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-183200242
Merging to master. Thanks, @redsanket
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10838
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-183200705
@redsanket what's your JIRA account name? I want to assign it to you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user redsanket commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-182911828
@zsxwing rebased and changed ArrayBuffer to HashSet
@tgravescs might want to take a look at it one more time
---
If your project is set up for it, you can reply
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/10838#discussion_r52653425
--- Diff: docs/configuration.md ---
@@ -392,6 +392,16 @@ Apart from these, the following properties are also
available, and may be useful
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-183027600
@redsanket most of my comments are minor. Otherwise LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/10838#discussion_r52653512
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -47,6 +47,7 @@ import org.apache.spark.util.Utils
*
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/10838#discussion_r52653442
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -169,7 +176,10 @@ final class ShuffleBlockFetcherIterator(
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/10838#discussion_r52654346
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -153,9 +158,11 @@ final class ShuffleBlockFetcherIterator(
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-182940338
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-182943209
**[Test build #51118 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51118/consoleFull)**
for PR 10838 at commit
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-182936370
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-182939705
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-182939709
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-183071484
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-183122765
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-183122543
**[Test build #51130 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51130/consoleFull)**
for PR 10838 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-183122764
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-183072553
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user redsanket commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-183063914
@zsxwing addressed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-183065836
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-183065989
LGTM. will merge this one once the tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-183079473
**[Test build #51130 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51130/consoleFull)**
for PR 10838 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-183071483
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-182993003
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-182992993
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-182991688
**[Test build #51118 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51118/consoleFull)**
for PR 10838 at commit
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/10838#discussion_r52519913
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -143,9 +148,11 @@ final class ShuffleBlockFetcherIterator(
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/spark/pull/10838#discussion_r52518306
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -143,9 +148,11 @@ final class
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/spark/pull/10838#discussion_r52564828
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -143,9 +148,11 @@ final class
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/spark/pull/10838#discussion_r52542439
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -143,9 +148,11 @@ final class
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/spark/pull/10838#discussion_r52541897
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -143,9 +148,11 @@ final class
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10838#discussion_r52542474
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -143,9 +148,11 @@ final class ShuffleBlockFetcherIterator(
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-181906980
@zswing any other comments, otherwise LGTM and I'll commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-181991403
Just a small nit. Otherwise, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-182148417
@redsanket could you rebase this PR? I found a bug when reviewing this PR
and fixed it in #11138 which made the conflicts.
---
If your project is set up for it, you
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/10838#discussion_r52345827
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -143,9 +148,11 @@ final class ShuffleBlockFetcherIterator(
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/10838#discussion_r52346381
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -143,9 +148,11 @@ final class ShuffleBlockFetcherIterator(
Github user redsanket commented on the pull request:
https://github.com/apache/spark/pull/10838#issuecomment-178209754
@zsxwing Updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
44 matches
Mail list logo
