Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5178
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-136894558
Let's close this patch and reopen it later if necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-121073615
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-113335190
@viper-kun @maropu any updates? Should we take over? I would recommend that
we close this patch since it's mostly gone stale. We can always reopen an
updated version
Github user viper-kun commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-94250246
@maropu I will update it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user viper-kun commented on a diff in the pull request:
https://github.com/apache/spark/pull/5178#discussion_r28650737
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/FileShuffleBlockManager.scala ---
@@ -180,7 +180,8 @@ class FileShuffleBlockManager(conf: SparkConf)
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-93917004
@viper-kun What's the status of this patch? If you don't make further
updates, I'd like to brush up this patch.
---
If your project is set up for it, you can reply to
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/5178#discussion_r27781900
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -181,68 +181,102 @@ final class ShuffleBlockFetcherIterator(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/5178#discussion_r27781922
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/FileShuffleBlockManager.scala ---
@@ -180,7 +180,8 @@ class FileShuffleBlockManager(conf: SparkConf)
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-89735823
Understood.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-89716003
@maropu , yeah i think it is a common case for yarn mode. We often specify
more executors than nodemanager, that means there are more than one executor on
one machine.
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/5178#discussion_r27719488
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala ---
@@ -223,6 +226,15 @@ class BlockManagerMasterActor(val isLocal:
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-89318869
One question; are there many cases for executors to share a single host in
the Yarn mode?
---
If your project is set up for it, you can reply to this email and have your
Github user viper-kun commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-88064150
@andrewor14 Pls review it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-87572136
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-87577323
[Test build #29391 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29391/consoleFull)
for PR 5178 at commit
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-87571847
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-87566631
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-87611637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-87535646
[Test build #29381 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29381/consoleFull)
for PR 5178 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-87552816
[Test build #29381 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29381/consoleFull)
for PR 5178 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-87552831
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-87547529
[Test build #29385 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29385/consoleFull)
for PR 5178 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-87370436
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-87370430
[Test build #29361 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29361/consoleFull)
for PR 5178 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-87369980
[Test build #29361 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29361/consoleFull)
for PR 5178 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-87370834
[Test build #29363 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29363/consoleFull)
for PR 5178 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-87378645
[Test build #29363 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29363/consoleFull)
for PR 5178 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-87378679
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-87212610
[Test build #29346 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29346/consoleFull)
for PR 5178 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-87212626
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-87201266
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user viper-kun commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-86849484
Hi @andrewor14. pls retest it, test build time out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-86906368
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-86906360
**[Test build #29296 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29296/consoleFull)**
for PR 5178 at commit
Github user WangTaoTheTonic commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-86878577
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-86879709
[Test build #29296 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29296/consoleFull)
for PR 5178 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-86430853
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-86430835
**[Test build #29217 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29217/consoleFull)**
for PR 5178 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-86433963
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-86433945
**[Test build #29218 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29218/consoleFull)**
for PR 5178 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-86805460
[Test build #29274 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29274/consoleFull)
for PR 5178 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-86828278
**[Test build #29274 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29274/consoleFull)**
for PR 5178 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-86828291
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-86383226
[Test build #29217 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29217/consoleFull)
for PR 5178 at commit
Github user viper-kun commented on a diff in the pull request:
https://github.com/apache/spark/pull/5178#discussion_r27193887
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -181,68 +181,100 @@ final class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-86388109
[Test build #29218 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29218/consoleFull)
for PR 5178 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/5178#discussion_r27157449
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
@@ -81,7 +89,38 @@ private[spark] class DiskBlockManager(blockManager:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-86183403
[Test build #29167 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29167/consoleFull)
for PR 5178 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-86183415
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/5178#discussion_r27156826
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala ---
@@ -52,9 +52,9 @@ class BlockManagerMasterActor(val isLocal:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-86182951
[Test build #29167 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29167/consoleFull)
for PR 5178 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/5178#discussion_r27159008
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
@@ -81,7 +89,38 @@ private[spark] class DiskBlockManager(blockManager:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/5178#discussion_r27159189
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
@@ -81,7 +89,38 @@ private[spark] class DiskBlockManager(blockManager:
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-86182102
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/5178#discussion_r27156748
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockManager.scala ---
@@ -52,12 +52,16 @@ class IndexShuffleBlockManager(conf:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/5178#discussion_r27157027
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala ---
@@ -223,6 +226,14 @@ class BlockManagerMasterActor(val isLocal:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/5178#discussion_r27159923
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
@@ -81,7 +89,38 @@ private[spark] class DiskBlockManager(blockManager:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/5178#discussion_r27161351
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -181,68 +181,100 @@ final class
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-86201608
Hi @viper-kun it seems that there are quite a few style violations. For
more detail please see
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5178#issuecomment-85807625
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user viper-kun opened a pull request:
https://github.com/apache/spark/pull/5178
[SPARK-6521][Core]executors in the same node read local shuffle file
In the past, executor read other executor's shuffle file in the same node
by net. This pr make that executors in the same node
62 matches
Mail list logo
