Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8746
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/8746#issuecomment-171396060
How about we close this PR for now and revisit it later?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/8746#issuecomment-157884801
I am not sure if we should do it now because it is still possible to have
nulls in a column defined as `NOT NULL`.
---
If your project is set up for it, you can reply to
Github user sabhyankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/8746#discussion_r45070100
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/DDLTestSuite.scala ---
@@ -113,4 +113,23 @@ class DDLTestSuite extends DataSourceTest with
Github user smola commented on a diff in the pull request:
https://github.com/apache/spark/pull/8746#discussion_r45063997
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/DDLTestSuite.scala ---
@@ -113,4 +113,23 @@ class DDLTestSuite extends DataSourceTest with
Github user sabhyankar commented on the pull request:
https://github.com/apache/spark/pull/8746#issuecomment-148177961
Hi @smola - Is there anything else that you need me to check for this PR?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8746#discussion_r42045738
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/DDLTestSuite.scala ---
@@ -113,4 +113,23 @@ class DDLTestSuite extends DataSourceTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8746#discussion_r41085142
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DDLParser.scala
---
@@ -173,13 +174,15 @@ class DDLParser(parseQuery: String
Github user sabhyankar commented on the pull request:
https://github.com/apache/spark/pull/8746#issuecomment-145291397
Thanks again @cloud-fan I have pushed a new commit with the updates!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8746#discussion_r41091308
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/DDLTestSuite.scala ---
@@ -17,6 +17,7 @@
package org.apache.spark.sql.sources
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8746#discussion_r41091305
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DDLParser.scala
---
@@ -173,13 +174,15 @@ class DDLParser(parseQuery: String
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/8746#issuecomment-145286982
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sabhyankar commented on the pull request:
https://github.com/apache/spark/pull/8746#issuecomment-145284551
@smola @cloud-fan Thanks again for the review guys. I have made the
additional changes that were noted.
---
If your project is set up for it, you can reply to this
Github user sabhyankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/8746#discussion_r41091143
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DDLParser.scala
---
@@ -173,13 +174,15 @@ class DDLParser(parseQuery: String
Github user sabhyankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/8746#discussion_r41091151
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/DDLTestSuite.scala ---
@@ -113,4 +124,20 @@ class DDLTestSuite extends DataSourceTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8746#discussion_r41085131
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/DDLTestSuite.scala ---
@@ -113,4 +124,20 @@ class DDLTestSuite extends DataSourceTest with
Github user sabhyankar commented on the pull request:
https://github.com/apache/spark/pull/8746#issuecomment-145031808
@smola Thanks for the review. I will add a test case for it and push
another commit today.
---
If your project is set up for it, you can reply to this email and
Github user sabhyankar commented on the pull request:
https://github.com/apache/spark/pull/8746#issuecomment-145143378
@smola I have added a test case for this. Let me know if you see anything
else that needs to be changed or added.
---
If your project is set up for it, you can
Github user smola commented on the pull request:
https://github.com/apache/spark/pull/8746#issuecomment-144693706
@sabhyankar Great! The implementation looks good. Could you add a test case
for it?
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user sabhyankar opened a pull request:
https://github.com/apache/spark/pull/8746
[SPARK-7012][SQL] Add support for NOT NULL modifier for column definitions
on DDLParser
Add support for NOT NULL modifier for column definitions in DDLParser
You can merge this pull request
Github user sabhyankar commented on the pull request:
https://github.com/apache/spark/pull/8746#issuecomment-140074649
@smola I have created this PR for SPARK-7012
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8746#issuecomment-140075775
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
22 matches
Mail list logo
