Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-116771070
@vanzin can you elaborate? Where is the offending line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-116774379
OK, I'm going to revert this patch. @vanzin would you mind submitting a fix?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-116772492
@andrewor14 It's not a particular line, it's the whole patch. The patch
ignores any application whose logs do not contain an application ID. No logs
generated by Spark
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-115313702
So, one thing that I noticed after I said LGTM is that this change breaks
old logs (those generated by versions of Spark that do not record the app id).
Those will never
Github user sujkh85 commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-115314720
NAVER - http://www.naver.com/
su...@naver.com ëê» ë³´ë´ì ë©ì¼ Re: [spark] [SPARK-8372] History
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6827#discussion_r32662931
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -282,8 +282,12 @@ private[history] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6827#discussion_r32663412
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -431,7 +435,9 @@ private[history] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6827#discussion_r32662634
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -282,8 +282,12 @@ private[history] class
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-112943729
Ok I'm going to merge this into master 1.4 after addressing the comments
myself thanks.
---
If your project is set up for it, you can reply to this email and have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/6827
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user carsonwang commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-111989257
Thanks @jerryshao . I updated the code as suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-112022587
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-112022559
[Test build #34928 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34928/console)
for PR 6827 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-111989597
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-111989379
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-111989525
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/6827#discussion_r32400880
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -282,8 +282,14 @@ private[history] class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-111989545
[Test build #34928 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34928/consoleFull)
for PR 6827 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-111990123
[Test build #34930 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34930/consoleFull)
for PR 6827 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-112023442
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-112023364
[Test build #34930 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34930/console)
for PR 6827 at commit
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/6827#discussion_r32400966
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -282,8 +282,14 @@ private[history] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6827#discussion_r32437068
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -160,7 +160,7 @@ private[history] class FsHistoryProvider(conf:
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-112120882
@jerryshao The `res.map { r =` version would be considered idiomatic Scala
style, not weird. In this case, there's not a lot of reason to prefer one
style over the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6827#discussion_r32486202
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
---
@@ -218,6 +223,18 @@ class FsHistoryProviderSuite extends
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-112254025
Yes, @jerryshao, the idiom is a little clearer when the contents of the
Option are actually be used to produce a result other than Unit, but it's also
a little odd
Github user carsonwang commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-112260070
Thanks for reviewing this, @vanzin . The code is updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user carsonwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6827#discussion_r32487191
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
---
@@ -218,6 +223,18 @@ class FsHistoryProviderSuite extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-112278245
[Test build #34967 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34967/console)
for PR 6827 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-112278349
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-112246206
Hi @markhamstra , I'm pretty sure about this style `o.map{ ... }.getOrElse{
... }`, but here we transfer nothing but only print some different logs, so
here using
Github user carsonwang commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-112258599
@vanzin SPARK-8275 is a different issue. What I wanted to fix in this PR is
to avoid showing an App ID like application_1432793609805_009_1.inprogress.
This is not a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-112260564
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-112260574
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-112260668
[Test build #34967 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34967/consoleFull)
for PR 6827 at commit
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6827#discussion_r32437127
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -282,8 +282,12 @@ private[history] class FsHistoryProvider(conf:
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-112124453
If the PR summary you mention:
This app info will never disappear even after the app is completed.
But I don't see that problem being fixed anywhere.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6827#discussion_r32437391
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
---
@@ -218,6 +223,18 @@ class FsHistoryProviderSuite extends
Github user carsonwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6827#discussion_r32485127
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
---
@@ -218,6 +223,18 @@ class FsHistoryProviderSuite extends
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-112261337
Ok, now I get what the patch is doing. LGTM with latest changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user carsonwang opened a pull request:
https://github.com/apache/spark/pull/6827
[SPARK-8372] History server shows incorrect information for application not
started
The history server may show an incorrect App ID for an incomplete
application like App ID.inprogress. This
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-111980322
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
42 matches
Mail list logo
