Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-123246180
Yeah, Looks good !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/6832
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-123250742
Merged into master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-123239100
Looks good to me. @ScrapCodes any more thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mallman commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-122957103
@srowen I've pushed a new commit to replace usage of
`dev/change-version-to-*.sh` scripts with `dev/change-scala-version.sh
version`. I also modified the latter so it
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-122955882
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-122955861
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mallman commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-122946797
@srowen I'm working on this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-122956830
[Test build #37848 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37848/consoleFull)
for PR 6832 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-122996753
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-122996557
[Test build #37848 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37848/console)
for PR 6832 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-122080379
Ping @mallman I think you can make the additional changes. I don't mind
just merging as is though, so will otherwise do that in a day or two.
---
If your project is set
Github user mallman commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-122112493
@srowen Sorry, I've been swamped. I think I can get this done by Saturday
if you want to wait.
---
If your project is set up for it, you can reply to this email and
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-121017249
@mallman I think you can go for it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mallman commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-120988236
@srowen @ScrapCodes Let me know if you'd like me to take on those
additional tasks. Cheers.
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-120269301
[Test build #1036 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1036/consoleFull)
for PR 6832 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-120282286
[Test build #1036 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1036/console)
for PR 6832 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-120363074
[Test build #1038 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1038/consoleFull)
for PR 6832 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-120403557
[Test build #1038 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1038/console)
for PR 6832 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-120414925
Looking strong @mallman. @ScrapCodes how about we finish this by:
- Deleting the `change-version-to-*` scripts
- Updating `dev/create-release.sh` to reflect
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6832#discussion_r34274335
--- Diff: dev/change-version-to-2.11.sh ---
@@ -17,10 +17,4 @@
# limitations under the License.
#
-# Note that this will not necessarily
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-120059461
[Test build #36943 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36943/consoleFull)
for PR 6832 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-120059202
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-120094398
[Test build #36943 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36943/console)
for PR 6832 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-120094452
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-120106890
[Test build #1024 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1024/consoleFull)
for PR 6832 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-120192196
[Test build #1026 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1026/consoleFull)
for PR 6832 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-120210786
[Test build #1026 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1026/console)
for PR 6832 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-120140856
[Test build #1024 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1024/console)
for PR 6832 at commit
Github user mallman commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-120059239
I've pushed a commit to implement the second strategy. I've tested this
script successfully on OS X Yosemite and Ubuntu 14.
---
If your project is set up for it, you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-120059186
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mallman commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-119708081
Thanks for the tip, @srowen. That works.
I now have a version following approach (2) which I've verified works on OS
X with its built-in sed. I'll test on a GNU
Github user mallman commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-119266285
I'll work on a revision following along the lines of what @ScrapCodes did
and push it to this PR. Incidentally, I was going to suggest we use `mktemp` to
create the
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-119114077
I think I also like option 2. On OS X I actually am not sure whether I have
GNU sed because of OS X or because of brew, so maybe slightly better not to
have to rely on
Github user mallman commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-119333018
I've run into a roadblock. This syntax:
sed -e
'0,/scala\.binary\.version2.10/s//scala.binary.version2.11/' pom.xml
doesn't work with my Mac's sed.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-119335853
`sed -e 's/scala\.binary\.version2\.10/scala.binary.version2.11/'
...` worked for me on Yosemite. Is that not standard syntax too? that's what I
always use with `sed`.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-119377246
I thought that would be fine but, yeah it changes the 2.11 in the 2.11
profile to 2.10 on the way back, which is wrong. I fished around a little more
and this seems to
Github user mallman commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-119375569
The original code replaces only the first instance of
`scala.binary.version2.10` in the file, which is the desired behavior. The
code you presented replaces all of
Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-119153050
I was also inclined towards having an echo (Like the one in script above.).
It gives the user necessary feedback, as to what changed.
---
If your project is set up
Github user mallman commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-118999888
I've spent some more time googling around this problem. Unsurprisingly,
there's plenty of discussion/frustration around finding a cross-platform
solution. There doesn't
Github user mallman commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-118743436
@srowen I just returned from my vacation abroad and am catching up. Sorry
for the wait. I'll take a look at this tomorrow. Cheers.
---
If your project is set up for
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-117951457
@mallman are you able to look at this further or should maybe @ScrapCodes
proceed with the changes he identified?
---
If your project is set up for it, you can reply to
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-116208009
@mallman what do you think about these changes instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-115570938
@ScrapCodes that works as intended and doesn't leave the -e files around
anymore, except that the update for `scala.binary.verison` does not work. This
seemed to work:
Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-115637219
Yes it looks simple, If you think this suggestion work for both gnu and bsd
systems. Can we update the patch accordingly ?
---
If your project is set up for it, you
Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-115530179
@srowen Did you get a chance to try the above out ? did it work ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-115210521
@srowen I tried it, all we need to do is drop the `-i` flag, which in-place
replaces the file. Instead we need to probably redirect the stream by correctly
setting
Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-115224669
Try this as `dev/change-version-to-2.11.sh` on OSX with bsd sed.
```bash
# Note that this will not necessarily work as intended with non-GNU sed
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-115211350
@ScrapCodes yes you can click the user link and report abuse. I have
already done that but please go ahead too.
If you mean you need an OS X system, I think we
Github user sujkh85 commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-115210717
NAVER - http://www.naver.com/
su...@naver.com ëê» ë³´ë´ì ë©ì¼ Re: [spark] [SPARK-8401] [Build]
Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-115210837
BTW: Is there a way to report spam in github ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-115201376
@ScrapCodes go for it but do you have a better solution in sight? would it
be reasonable to merge this as a step forward?
---
If your project is set up for it, you can
Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-113480419
I am inclined towards having sed replacement command which is compatible
with POSIX (works both on bsd and GNU). I do not have a BSD system handy right
now. :/ to
Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-113498883
I am going to give it a shot, if you allow me some time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-113482545
Yeah me too but I remember being unable to figure it out when I took a shot
at it, and I assume you couldn't either. This at least uses GNU sed
consistently.
---
If
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-113457337
@ScrapCodes any thoughts? otherwise LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mallman commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-113548582
Sure thing. FYI, I'm leaving for Iceland tomorrow (Saturday), and I'll be
away for two weeks. I will probably be incommunicado during this time. If you
need something
Github user mallman commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-113206728
Indeed the build does generate the scaladoc in the right location, but the
`docs/_plugin/copy_api_dirs.rb` is currently hardcoded to always look for the
api docs in
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-113283187
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-113283399
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-113283374
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-113283574
[Test build #35166 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35166/consoleFull)
for PR 6832 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-113306647
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-113306622
[Test build #35166 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35166/console)
for PR 6832 at commit
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/6832#discussion_r32703376
--- Diff: dev/change-scala-version.sh ---
@@ -0,0 +1,63 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-113080507
Looking good -- what's the need for the scaladoc update? wouldn't the build
generate the scaladoc with the right location and name once the build is
updated? Maybe
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6832#discussion_r32659702
--- Diff: dev/change-scala-version.sh ---
@@ -0,0 +1,63 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6832#discussion_r32600616
--- Diff: dev/change-scala-version.sh ---
@@ -0,0 +1,63 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6832#discussion_r32600697
--- Diff: dev/change-scala-version.sh ---
@@ -0,0 +1,63 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/6832#discussion_r32649538
--- Diff: dev/change-scala-version.sh ---
@@ -0,0 +1,63 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6832#discussion_r32649638
--- Diff: dev/change-scala-version.sh ---
@@ -0,0 +1,63 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/6832#discussion_r32650306
--- Diff: dev/change-scala-version.sh ---
@@ -0,0 +1,63 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under
Github user mallman commented on the pull request:
https://github.com/apache/spark/pull/6832#issuecomment-112608540
@srowen I created the Jira ticket which shows the problem with the current
version changing scripts.
---
If your project is set up for it, you can reply to this email
73 matches
Mail list logo
