Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-168101168
LGTM. Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10402
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-167516759
**[Test build #48362 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48362/consoleFull)**
for PR 10402 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-167520443
**[Test build #48363 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48363/consoleFull)**
for PR 10402 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-167539426
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-167539345
**[Test build #48362 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48362/consoleFull)**
for PR 10402 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-167539427
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-167542344
**[Test build #48363 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48363/consoleFull)**
for PR 10402 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-167542409
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-167542410
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10402#discussion_r48495547
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -327,9 +327,9 @@ abstract class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10402#discussion_r48495956
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -327,9 +327,9 @@ abstract class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10402#discussion_r48496502
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -327,9 +327,9 @@ abstract class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-167070921
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-167070923
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-167070865
**[Test build #48294 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48294/consoleFull)**
for PR 10402 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-167060193
**[Test build #48294 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48294/consoleFull)**
for PR 10402 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10402#discussion_r48186892
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -421,6 +460,19 @@ case class CumeDist()
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-166408658
@hvanhovell Regarding the doc, we can acknowledge them (Hive and Presto) in
the scala doc.
---
If your project is set up for it, you can reply to this email and have
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-166400507
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-166385561
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-166392842
I guess you also need to put `extended` like the example `Upper` given by
@yhuai ?
---
If your project is set up for it, you can reply to this email and have your
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-166399280
@gatorsmile extended is typically used to give an example of how the
functions is used. See:
23 matches
Mail list logo
