Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/7070
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-118092178
@thegiive Thanks for working on this! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user thegiive commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-118172236
Thanks you. @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33709641
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetSchemaMergeConfigSuite.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33704993
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetSchemaMergeConfigSuite.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33704971
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/parquet/newParquet.scala ---
@@ -113,8 +113,9 @@ private[sql] class ParquetRelation2(
}
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33704979
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetSchemaMergeConfigSuite.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33704974
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetSchemaMergeConfigSuite.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33704967
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -227,6 +227,13 @@ private[spark] object SQLConf {
defaultValue =
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33705001
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetSchemaMergeConfigSuite.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33704981
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetSchemaMergeConfigSuite.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33704983
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetSchemaMergeConfigSuite.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33704964
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -227,6 +227,13 @@ private[spark] object SQLConf {
defaultValue =
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33704987
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetSchemaMergeConfigSuite.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33709558
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetSchemaMergeConfigSuite.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-117691515
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-117691410
[Test build #36259 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36259/console)
for PR 7070 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-117640314
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-117640309
[Test build #36247 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36247/console)
for PR 7070 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-117645648
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-117646028
[Test build #36259 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36259/consoleFull)
for PR 7070 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-117645665
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user thegiive commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-117645649
Hi @liancheng , Can you help to check if it is what you suggest ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-117638651
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-117638034
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-117639661
[Test build #36247 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36247/consoleFull)
for PR 7070 at commit
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33705216
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetSchemaMergeConfigSuite.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33704998
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetSchemaMergeConfigSuite.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33704989
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetSchemaMergeConfigSuite.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-117769340
@thegiive I left several comments on styling issues, otherwise your changes
looks pretty good to me now. The [Databricks Scala style guide] [1] and [Spark
code style
Github user thegiive commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-117893056
HI @liancheng , thanks for the suggestion. I think your comment is really
good and I have modified it already.
Please help to check if there is anything else
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-117841999
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-117842016
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-117842694
[Test build #36310 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36310/consoleFull)
for PR 7070 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-117858416
[Test build #36310 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36310/console)
for PR 7070 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-117858478
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user thegiive commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-117364855
Sure. I have already finish the coding. But I need some more time to write
the test case
---
If your project is set up for it, you can reply to this email and have
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-116882483
Thanks for contributing this! This feature looks good, but still requires
some more polishing:
1. Please fix the style issues as I commented.
1.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-116875210
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-116875229
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-116875664
[Test build #36048 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36048/consoleFull)
for PR 7070 at commit
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-116875110
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-116875893
[Test build #36048 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36048/console)
for PR 7070 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-116875940
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7070#discussion_r33528070
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/parquet/newParquet.scala ---
@@ -114,7 +114,7 @@ private[sql] class ParquetRelation2(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-116253471
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user thegiive opened a pull request:
https://github.com/apache/spark/pull/7070
[Spark-8690][SQL] Add a setting to disable SparkSQL parquet schema merge by
using datasource API
The detail problem story is in
https://issues.apache.org/jira/browse/SPARK-8690
General
47 matches
Mail list logo
