Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34830515
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ericl commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-122069902
Sounds good, I'll look at the R integration next.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/7381
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121817685
LGTM except some minor comments, which we can fix in the next PR. Merged
into master. Thanks! As the next step, we can create a wrapper for `RFormula +
LinearRegression`
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34753039
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/RModelFormulaSuite.scala ---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34753079
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121776334
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121776348
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121776841
[Test build #37425 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37425/consoleFull)
for PR 7381 at commit
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34742755
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/RModelFormulaSuite.scala ---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34742729
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34742685
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34742784
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/RModelFormulaSuite.scala ---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software
Github user ericl commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121777321
@mengxr That makes sense, I'll do that in a followup PR. I also addressed
the comments.
---
If your project is set up for it, you can reply to this email and have your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121785607
[Test build #37425 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37425/console)
for PR 7381 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121778102
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121778086
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121778232
[Test build #37426 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37426/consoleFull)
for PR 7381 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121785796
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121788896
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121788851
[Test build #37426 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37426/console)
for PR 7381 at commit
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34618001
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/RModelFormulaSuite.scala ---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34617993
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/VectorAssembler.scala ---
@@ -116,7 +116,7 @@ class VectorAssembler(override val uid: String)
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34617858
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34617767
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34617756
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34617760
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34617742
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34617806
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34617741
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34617888
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34618021
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/RModelFormulaSuite.scala ---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34617985
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34617695
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34632802
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34632796
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121430082
[Test build #37282 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37282/consoleFull)
for PR 7381 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121429679
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121429694
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34632816
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34632827
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/VectorAssembler.scala ---
@@ -116,7 +116,7 @@ class VectorAssembler(override val uid: String)
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34632829
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/RModelFormulaSuite.scala ---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34632824
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34632806
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34632795
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34632811
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34632800
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34632803
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121433780
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34637543
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/RModelFormulaSuite.scala ---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34637538
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34637540
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34637533
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34637537
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34637535
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34637529
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34637545
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/RModelFormulaSuite.scala ---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34637544
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/RModelFormulaSuite.scala ---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34632817
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34632833
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/RModelFormulaSuite.scala ---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121433740
[Test build #37282 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37282/console)
for PR 7381 at commit
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34643356
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/RModelFormulaSuite.scala ---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34643345
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/VectorAssembler.scala ---
@@ -116,7 +116,7 @@ class VectorAssembler(override val uid: String)
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34643347
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/RModelFormulaSuite.scala ---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34643358
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/RModelFormulaSuite.scala ---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34643348
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/RModelFormulaSuite.scala ---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34643578
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/RModelFormulaSuite.scala ---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121485499
@ericl I make another pass. The major issue is actually that
`RModelFormula` should be an `Estimator` instead of a `Transformer` in order to
handle String columns. It
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7381#discussion_r34643726
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/RModelFormula.scala ---
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121099053
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121102812
[Test build #37170 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37170/consoleFull)
for PR 7381 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121099480
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121107200
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121107144
[Test build #37170 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37170/console)
for PR 7381 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121102610
[Test build #37167 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37167/consoleFull)
for PR 7381 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121102116
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user ericl opened a pull request:
https://github.com/apache/spark/pull/7381
[SPARK-8774] [ML] Add R model formula with basic support as a transformer
This implements minimal R formula support as a feature transformer. Both
numeric and string labels are supported, but
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121099302
[Test build #37166 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37166/consoleFull)
for PR 7381 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121099478
[Test build #37166 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37166/console)
for PR 7381 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121102765
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121102101
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121102778
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121099063
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121108982
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121108947
[Test build #37167 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37167/console)
for PR 7381 at commit
85 matches
Mail list logo
