[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-05-18 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-220069649 Hi everyone, sorry this has sat around for so long, but this is a super important feature, so I'd like to finish up the missing pieces and get this in (with credit to

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-187586804 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-187586803 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-187586614 **[Test build #51737 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51737/consoleFull)** for PR 8760 at commit

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-22 Thread mwws
Github user mwws commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-187548596 Besides from what @squito stated above, I have simplified the configuration to resolve @kayousterhout 's concern. By default, exact same blacklist logic will be applied as

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-187547524 **[Test build #51737 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51737/consoleFull)** for PR 8760 at commit

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-18 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-185965488 @kayousterhout @markhamstra one other thing to follow up on was the earlier idea of using speculation to test out whether blacklisted executors can be added back. While

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-18 Thread mwws
Github user mwws commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-185602366 @chenghao-intel Sure, I will update soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-17 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-185212009 @mwws can you update the code? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-17 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r53165346 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistStrategy.scala --- @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-11 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r52685053 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-11 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r52682469 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -21,6 +21,7 @@ import java.util.Collections import

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-11 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r52681082 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-11 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r52681156 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -270,19 +260,11 @@ private[spark] class TaskSetManager(

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-11 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r52681359 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -0,0 +1,226 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-01-26 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-175342880 @mwws can you rebase the code? @kayousterhout any more comments on this? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-171210808 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-01-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-171210609 **[Test build #49294 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49294/consoleFull)** for PR 8760 at commit

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-171210806 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-171180163 **[Test build #49294 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49294/consoleFull)** for PR 8760 at commit

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-01-10 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-170442019 @squito @kayousterhout @mridulm do you have any further comments on this? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-01-10 Thread mwws
Github user mwws commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-170444236 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-01-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-170445768 **[Test build #49099 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49099/consoleFull)** for PR 8760 at commit

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-01-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-170446175 **[Test build #49099 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49099/consoleFull)** for PR 8760 at commit

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-01-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-170446186 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-01-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-170446190 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-167728825 **[Test build #48401 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48401/consoleFull)** for PR 8760 at commit

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-12-28 Thread mwws
Github user mwws commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-167728914 @mridulm I have changed the interface a little bit and create `AdvancedSingleTaskStrategy` to support the use case you described above. With this new strategy, we enable

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-167741271 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-167741274 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-167741137 **[Test build #48401 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48401/consoleFull)** for PR 8760 at commit

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-12-23 Thread mwws
Github user mwws commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-167052293 @squito @mridulm I am afraid an additional state can not help here, your use case requires "TaskSet related nodeBlacklist" which is not supported with current

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-12-16 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-165280794 @mridulm going back to one of your previous comments: > What would be more ideal is an implementation which allows for blacklisting single task (as is current),

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-12-16 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-165279831 @markhamstra I'm not entirely sure I understand the idea of de-blacklisting executors via speculation. The two seem rather independent, and I'm actually pretty

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-12-16 Thread mridulm
Github user mridulm commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-165304077 @squito Unless an executor or node is dying/has resource issues, in most cases, the failure is not repeatable across tasksets due to differing execution/resource

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-12-03 Thread markhamstra
Github user markhamstra commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-161729752 I still like the idea of using speculative tasks to parole blacklisted executors and hosts, but that new role for speculative execution will complicate

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-12-01 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-161100737 @kayousterhout this is pretty important for users running clusters with a larger clusters, eg. a few hundred nodes. We've seen cases where there is some weird

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-12-01 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-161132665 I had one other idea here: for blacklisted executors / hosts, we *could* periodically run a speculative copy of a task there. If the task succeeds, we can

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-12-01 Thread markhamstra
Github user markhamstra commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-161133600 @kayousterhout Yeah, that's kind of interesting -- kind of like "arbeit macht frei", except it's not a lie. Probably shouldn't have gone there --- If your

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-12-01 Thread mwws
Github user mwws commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-161165662 @kayousterhout I believe in most of case user just can just use default configuration or set `spark.scheduler.blacklist.strategy` to `executorAndNode`. I also like idea

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-12-01 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-161070513 Before fixing style issues on this change, I think it's worth considering whether this is the right approach for blacklisting. Based on discussion here and in

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-12-01 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r46249345 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-12-01 Thread mridulm
Github user mridulm commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-160890985 Since I am no longer very familiar with scheduler codebase, I am sort of giving up on my review halfway through - save the notes already added. Hopefully someone else

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-30 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-160728616 @davies thanks -- part of what I was wondering is whether the existing blacklist mechanism is good enough, since many of the potential issues mentioned seem like

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-30 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-160707369 @davies is this the issue you were running into recently (Patrick mentioned you'd been experiencing a similar issue)? --- If your project is set up for it, you

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-30 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-160709640 @kayousterhout I ran into a issue with bad host (a library can't be installed), it could be workarounded by specify the spark.scheduler.executorTaskBlacklistTime,

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-30 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-160734431 I remembered why this discussion sounds so familiar: there was a long discussion about host-level blacklisting on this PR:

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-30 Thread mwws
Github user mwws commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-160814564 `spark.scheduler.executorTaskBlacklistTime` is renamed to `spark.scheduler.blacklist.timeout` in this PR to make blacklist related configuration following unified pattern

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-30 Thread mwws
Github user mwws commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-160864884 @kayousterhout It's an interesting discussion on PR: #3541. As I understand, this PR can satisfy both use case. For @davies , you might want to use

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-30 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r46247212 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistStrategy.scala --- @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-30 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r46248240 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-30 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r46248217 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-30 Thread mridulm
Github user mridulm commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-160884866 What would be more ideal is an implementation which allows for blacklisting single task (as is current), to multiple tasks for a taskset on a single executor (in case

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-160490927 **[Test build #46861 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46861/consoleFull)** for PR 8760 at commit

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-160505192 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-160505191 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-160505134 **[Test build #46861 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46861/consoleFull)** for PR 8760 at commit

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-29 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-160506398 This seems potentially useful, but adds a lot of complexity. Can you elaborate on the use cases where this problem has been arising? My vague memory of previous

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-29 Thread mwws
Github user mwws commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-160544588 @kayousterhout For example, task can failed because some host can't access source/network, local storage of some host is full, broken class linkage and other run-time

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-160076073 **[Test build #46811 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46811/consoleFull)** for PR 8760 at commit

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-160107616 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-160107618 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-160107546 **[Test build #46811 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46811/consoleFull)** for PR 8760 at commit

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-26 Thread mwws
Github user mwws commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r46021072 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -636,7 +622,8 @@ private[spark] class TaskSetManager(

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45793155 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45792679 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45790406 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45790885 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45790903 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-159402366 sorry for the delay again, @mwws, thanks for updating. My comments are now just cosmetic. As its a scheduler change, pinging the usual folks: @markhamstra

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45791721 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistStrategy.scala --- @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45791494 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistStrategy.scala --- @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45790035 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45788633 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistStrategy.scala --- @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45792961 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45769593 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45769579 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45755713 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45756928 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45756966 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45761465 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45761512 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45756368 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -636,7 +622,8 @@ private[spark] class TaskSetManager(

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45756677 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45756736 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45759735 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45756882 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45757164 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45771875 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistStrategy.scala --- @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45755581 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45755594 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45756446 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -34,6 +34,8 @@ import org.apache.spark.scheduler.SchedulingMode._

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45759807 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45760745 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -21,10 +21,12 @@ import java.util.Collections import

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45751778 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistStrategy.scala --- @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45751946 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistStrategy.scala --- @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45752011 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistStrategy.scala --- @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45752836 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistStrategy.scala --- @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45752965 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistStrategy.scala --- @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2015-11-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r45753251 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistStrategy.scala --- @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software

  1   2   3   4   >