[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-185966335 **[Test build #51502 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51502/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-185966344 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-185966348 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-185965746 **[Test build #51502 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51502/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-18 Thread GayathriMurali
Github user GayathriMurali closed the pull request at: https://github.com/apache/spark/pull/11140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-16 Thread GayathriMurali
Github user GayathriMurali commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-184842753 @JoshRosen @zsxwing I am currently trying to fix a null pointer exception. But on digging deeper, I see that there is no control over the daemon thread. It

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-15 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-184512589 No comment on the contents of this PR (since I haven't looked at them), but I did want to note that I think that the pull request description is a little thin here.

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-184091762 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-184091767 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-184091233 **[Test build #51294 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51294/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-184071981 **[Test build #51294 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51294/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-184064541 **[Test build #51293 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51293/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-184064595 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-184064594 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-184043728 **[Test build #51293 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51293/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-183227808 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-183227812 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-183227646 **[Test build #51175 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51175/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-12 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11140#discussion_r52812148 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala --- @@ -892,27 +911,30 @@ private[spark] class PythonBroadcast(@transient var

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-12 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11140#discussion_r52812799 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala --- @@ -892,27 +911,30 @@ private[spark] class PythonBroadcast(@transient var

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-12 Thread GayathriMurali
Github user GayathriMurali commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-183537578 @zsxwing I dont have a constructor to do object initialization for the FilePhantomReferences class. I am guessing that could also be causing python broadcast to

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-11 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-183198830 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-183201556 **[Test build #51175 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51175/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-11 Thread GayathriMurali
Github user GayathriMurali commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-183141770 ![image](https://cloud.githubusercontent.com/assets/7002441/12996389/39b20914-d0e4-11e5-8be5-5d6da97baf6e.png) Test build failed spark unit tests. But I

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-183136045 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-183135618 **[Test build #51134 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51134/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-183136043 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-183088846 **[Test build #51134 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51134/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182506639 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182506635 **[Test build #51038 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51038/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182506641 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182529110 **[Test build #51044 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51044/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182521814 **[Test build #51041 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51041/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182577329 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182577111 **[Test build #51044 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51044/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182577331 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182506287 **[Test build #51038 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51038/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182522659 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182522650 **[Test build #51041 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51041/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182522662 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11140#discussion_r52544162 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala --- @@ -18,12 +18,17 @@ package org.apache.spark.api.python import

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11140#discussion_r52544228 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala --- @@ -874,10 +890,14 @@ private class PythonAccumulatorParam(@transient private

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11140#discussion_r52544259 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala --- @@ -889,30 +909,32 @@ private[spark] class PythonBroadcast(@transient var path:

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-10 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182634439 @GayathriMurali thanks for doing this, but can you please fix all the style violations you have? The changes should indent the code blocks consistently. --- If

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-09 Thread GayathriMurali
GitHub user GayathriMurali opened a pull request: https://github.com/apache/spark/pull/11140 SPARK-12729 PhantomReferences to replace Finalize() PhantomReference to replace finalize() method in Python Broadcast. You can merge this pull request into a Git repository by running:

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-09 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182112607 Thanks for making this PR - at first glance there are some minor styling issues that might be good to fix (see our style guide at

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182069521 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-09 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/11140#discussion_r52374340 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala --- @@ -892,27 +911,31 @@ private[spark] class PythonBroadcast(@transient var

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-09 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/11140#discussion_r52374381 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala --- @@ -865,6 +869,17 @@ private class PythonAccumulatorParam(@transient private

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-09 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182128137 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182132144 **[Test build #51003 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51003/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-09 Thread GayathriMurali
Github user GayathriMurali commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182127382 Fixed styling issues. Please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182132682 **[Test build #51003 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51003/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182132693 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182132689 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-09 Thread GayathriMurali
Github user GayathriMurali commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182136487 Recent commit fixes all the styling bugs reported. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182138833 **[Test build #51006 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51006/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182139322 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182139321 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182139316 **[Test build #51006 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51006/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182205390 **[Test build #51024 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51024/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182206121 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182206130 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-182206105 **[Test build #51024 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51024/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-09 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11140#discussion_r52418903 --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala --- @@ -889,30 +910,31 @@ private[spark] class PythonBroadcast(@transient var