[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user techaddict closed the pull request at: https://github.com/apache/spark/pull/571 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-42376474 Talked with TD offline and he was okay with changing the package name, so I've merged this in. Thanks Sandeep! --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user tdas commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-42350365 @mateiz I dont think that decision is that big a deal. Its fairly obvious if one sees a streaming folder inside spark/ that those are streaming examples. It feels more incons

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-42349536 @mateiz So this is good to merge. ? On May 7, 2014 1:13 AM, "Matei Zaharia" wrote: > > BTW the other point of this was to make them consistent across package

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-42349293 BTW the other point of this was to make them consistent across packages, and MLlib and all the Python examples are under examples/ already. --- If your project is set up f

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-42349226 @tdas @techaddict let's not move them IMO. There are two reasons: First, when you browse the folder tree, you want to get into spark/examples and immediately see subfolders

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-42283416 @tdas ok I'll move streaming examples to "org.apache.spark.streaming.examples.*" as you suggest. Any other changes @mateiz --- If your project is set up for it, you

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user tdas commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41866376 No, I have strong feelings against "org.apache.spark.examples.streaming.*" This is entirely inconsistent with rest of the API. --- If your project is set up for it, you can

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41835064 @mateiz ready for merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41766159 @techaddict It looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41765699 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14582/ --- If your project

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41765698 Build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41765491 @mengxr @47ef86c392badc58052a0414115e49c2970b31eb looks good ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41765289 I would say using `org.apache.spark.examples` for now, which requires little code change. Then we try to avoid using `private[spark]` in examples. Maybe there is an automat

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41762289 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41762297 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41761434 @mengxr what do you suggest how should we resolve the private[spark] problem ? --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41761038 @techaddict I don't see anything necessary except the one using `private[spark]` or `private[streaming]` methods. For consistency, `org.apache.examples` may be better becau

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41758235 @mengxr so what changes should i make other than streaming one suggested by tdas. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user tdas commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41738665 Okay. As I said earlier, I find it more consistent to keep it as "org.apache.spark.streaming.examples.*" --- If your project is set up for it, you can reply to this email an

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41736493 No strong opinions here other than we should be consistent. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user tdas commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41729308 Bringing @marmbrust into this discussion as he had added the Spark SQL examples in `org.apache.spark.sql.examples`. --- If your project is set up for it, you can reply to t

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user tdas commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41729089 Oops, sorry for the confusion. I meant "latter" instead of "former". That is, I prefer `org.apache.spark.streaming.examples` over `org.apache.spark.examples.streaming.`, beca

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41727368 @tdas I'm a little confused. Which one do you prefer, `examples.streaming` or `streaming.examples`? --- If your project is set up for it, you can reply to this email and h

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/571#discussion_r12110060 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/util/RawTextHelper.scala --- @@ -22,10 +22,10 @@ import org.apache.spark.SparkContext._ import

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user tdas commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41715664 I have a general question about what should file and package organization of the examples be. For example, for Spark Streaming, is `org.apache.spark.examples.streaming.*` bet

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41701264 @mengxr IMO we should re-implement the necessary private functions in the examples, they are not too many just 2-3 methods. It will make using/modifying the examples e

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41700284 I know this is a little weird, but either `org.apache.examples.spark` or `org.apache.spark_examples` can help prevent using `private[spark]` classes. --- If your project i

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41644278 @mengxr I'm pretty sure we are only allowed to release classes in the org.apache namespace (unfortunately). --- If your project is set up for it, you can reply to this e

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41643711 If Apache allows to use a name space not starting with `org.apache`, I would recommend using `spark.examples` instead of `org.apache.spark.examples`. It also saves some typ

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/571#discussion_r12080334 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/util/RawTextHelper.scala --- @@ -22,10 +22,10 @@ import org.apache.spark.SparkContext._ impor

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41642259 @mengxr ya exactly, thats why i commented on the private[spark] change. I think better way would be to make the examples use there own methods, in case of private metho

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41642098 One question: is `org.apache.spark.examples` a good place for examples? Examples here have access to `private[spark]` classes. If we are not careful, users may have trouble

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41633981 @rxin so this is complete then ? On Apr 29, 2014 5:00 AM, "Xiangrui Meng" wrote: > @techaddict I moved main methods to >

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41626897 @techaddict I moved main methods to `examples/mllib` in https://github.com/apache/spark/pull/584 --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41613657 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14539/ --- If your project

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41613655 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41609618 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41609604 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41609032 Jenkins, add to whitelist and test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41506449 @mateiz We already have KMeans, LogisticRegressionWithSGD and other implementation examples as main functions in their respective objects. And can you whitelist me f

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41492818 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/571#issuecomment-41491550 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

Github user techaddict commented on a diff in the pull request: https://github.com/apache/spark/pull/571#discussion_r12028250 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/util/RawTextHelper.scala --- @@ -22,10 +22,10 @@ import org.apache.spark.SparkContext._ i

[GitHub] spark pull request: SPARK-1637: Clean up examples for 1.0

GitHub user techaddict opened a pull request: https://github.com/apache/spark/pull/571 SPARK-1637: Clean up examples for 1.0 1. Move all of them into subpackages of org.apache.spark.examples (right now some are in org.apache.spark.streaming.examples, for instance, and others are in