[GitHub] spark pull request: SPARK-3837. Warn when YARN kills containers fo...

2014-11-11 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/2744#issuecomment-62662666 @jdanbrown that seems reasonable. Mind filing a JIRA for it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: SPARK-3837. Warn when YARN kills containers fo...

2014-11-11 Thread jdanbrown
Github user jdanbrown commented on the pull request: https://github.com/apache/spark/pull/2744#issuecomment-62656350 @sryza I came across your PR while searching for ways to debug pyspark yarn containers running over yarn memory limits. This change will be very helpful; what are your

[GitHub] spark pull request: SPARK-3837. Warn when YARN kills containers fo...

2014-10-31 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/2744#issuecomment-61319258 I have a commit to just comment out the test at https://github.com/shivaram/spark-1/compare/fix-yarn-build?expand=1 -- But if you have a better fix, we can use that. -

[GitHub] spark pull request: SPARK-3837. Warn when YARN kills containers fo...

2014-10-31 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/2744#issuecomment-61319062 I'll look into it > On Oct 31, 2014, at 12:36 PM, Shivaram Venkataraman wrote: > > This patch seems to have broken the build ? See https://amplab.cs.berk

[GitHub] spark pull request: SPARK-3837. Warn when YARN kills containers fo...

2014-10-31 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/2744#issuecomment-61317915 This patch seems to have broken the build ? See https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-Maven-with-YARN/HADOOP_PROFILE=hadoop-2.4,label=centos/821/console

[GitHub] spark pull request: SPARK-3837. Warn when YARN kills containers fo...

2014-10-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2744 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: SPARK-3837. Warn when YARN kills containers fo...

2014-10-31 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/2744#issuecomment-61261231 looks good. thanks @sryza! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-3837. Warn when YARN kills containers fo...

2014-10-29 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/2744#issuecomment-61026172 Updated patch incorporates review comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark pull request: SPARK-3837. Warn when YARN kills containers fo...

2014-10-29 Thread sryza
Github user sryza commented on a diff in the pull request: https://github.com/apache/spark/pull/2744#discussion_r19580322 --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -330,12 +331,21 @@ private[yarn] abstract class YarnAllocator(

[GitHub] spark pull request: SPARK-3837. Warn when YARN kills containers fo...

2014-10-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/2744#discussion_r19492068 --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -463,3 +473,19 @@ private[yarn] abstract class YarnAllocator(

[GitHub] spark pull request: SPARK-3837. Warn when YARN kills containers fo...

2014-10-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/2744#discussion_r19491803 --- Diff: yarn/common/src/test/scala/org/apache/spark/deploy/yarn/YarnAllocatorSuite.scala --- @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Softwar

[GitHub] spark pull request: SPARK-3837. Warn when YARN kills containers fo...

2014-10-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/2744#discussion_r19491256 --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -330,12 +331,21 @@ private[yarn] abstract class YarnAllocator(

[GitHub] spark pull request: SPARK-3837. Warn when YARN kills containers fo...

2014-10-28 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/2744#discussion_r19472179 --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -330,12 +331,21 @@ private[yarn] abstract class YarnAllocator(

[GitHub] spark pull request: SPARK-3837. Warn when YARN kills containers fo...

2014-10-28 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/2744#issuecomment-60758160 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-3837. Warn when YARN kills containers fo...

2014-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2744#issuecomment-58605744 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2

[GitHub] spark pull request: SPARK-3837. Warn when YARN kills containers fo...

2014-10-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2744#issuecomment-58605740 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21564/consoleFull) for PR 2744 at commit [`af11185`](https://github.com/a

[GitHub] spark pull request: SPARK-3837. Warn when YARN kills containers fo...

2014-10-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2744#issuecomment-58602302 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21564/consoleFull) for PR 2744 at commit [`af11185`](https://github.com/ap

[GitHub] spark pull request: SPARK-3837. Warn when YARN kills containers fo...

2014-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2744#issuecomment-58602139 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: SPARK-3837. Warn when YARN kills containers fo...

2014-10-09 Thread sryza
GitHub user sryza opened a pull request: https://github.com/apache/spark/pull/2744 SPARK-3837. Warn when YARN kills containers for exceeding memory limits I verified triggered the issue and verified the message gets printed on a pseudo-distributed cluster. You can merge this pull r