Github user jacek-lewandowski commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-65356790
So - can I close this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jacek-lewandowski commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-65356699
Here is the new PR https://github.com/apache/spark/pull/3571
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-65330260
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-65330247
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24059/consoleFull)
for PR 2739 at commit
[`f24d854`](https://github.com/a
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-65323531
Oh yeah - this is still against 1.1. @jacek-lewandowski can you open a new
PR and close this one?
---
If your project is set up for it, you can reply to this email and
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-65322917
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24059/consoleFull)
for PR 2739 at commit
[`f24d854`](https://github.com/ap
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-65322205
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-65321102
If you don't believe it's your fault, it will be much easier to help if you
create the new PR and an admin triggers a jenkins job to test it. Then we can
see whether it's
Github user jacek-lewandowski commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-65314387
I still have got one test failing:
```
[info] InputOutputMetricsSuite:
[info] - input metrics when reading text file with single split (34
milliseco
Github user jacek-lewandowski commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-65280862
@vanzin yeah, thats right
I tried running the real jobs before rebasing and they worked :)
---
If your project is set up for it, you can reply to this emai
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-65280103
I think `dev/run-tests` will run more comprehensive checks. Also, always a
good idea to try such a thing yourself on real jobs, aside from the unit tests.
:-)
You
Github user jacek-lewandowski commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-65279317
@vanzin already did that. Now I'm running tests - is there a new procedure
for testing? Or just sbt clean assembly test?
I can see one test failure whic
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-65278543
@jacek-lewandowski please work on top of master. We can work on backporting
it to branch-1.2 if there's a strong desire for it, but new features should
always be checked i
Github user jacek-lewandowski commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-65216596
Back to working on this... I've rebased against branch-1.2 and then I'll
rebase against master if you want.
---
If your project is set up for it, you can reply
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-63716956
@jacek-lewandowski are you still working on this? If you don't plan to
continue working on this I'd like to pick it up. Thanks!
---
If your project is set up for it, you
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-62344790
@jacek-lewandowski do you have any sense of when you'll be able to do this?
It would be great to get this into master soon!
---
If your project is set up for it, you ca
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60592413
Please also update the documentation. docs/security.md and the big comment
header at the top of SecurityManager.scala
---
If your project is set up for it, you can re
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60499825
Hi @jacek-lewandowski,
Do you mind re-opening this pull request against the `master` branch, since
this is targeted for 1.2?
---
If your project is set
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60312679
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60312673
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22080/consoleFull)
for PR 2739 at commit
[`f24d854`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60302418
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22080/consoleFull)
for PR 2739 at commit
[`f24d854`](https://github.com/ap
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60300403
You may want to add that file to `.rat-excludes` (unless you plan to rework
this on top of master and get rid of the file altogether :-)).
---
If your project is set up f
Github user jacek-lewandowski commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60298244
@vanzin fyi:
```
=
Running Apache RAT checks
=
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60297858
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22079/consoleFull)
for PR 2739 at commit
[`77591cb`](https://github.com/a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60297862
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22
Github user jacek-lewandowski commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60297784
@JoshRosen will it be retested automatically after commit ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user jacek-lewandowski commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60297608
@vanzin I'll thing about this for a while.
Still, I don't know why the test fail - I successfully run them locally.
---
If your project is set up for
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60297509
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22079/consoleFull)
for PR 2739 at commit
[`77591cb`](https://github.com/ap
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60275209
Hi @jacek-lewandowski,
Now that I finally noticed you built this on top of branch-1.1, some of the
choices you made make a lot more sense. (I always assume people
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60182904
Ah, also, about the branch thing... it would probably be better to have
this go into master first.
---
If your project is set up for it, you can reply to this email and h
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60182463
There's still sensitive data that may go in control messages; e.g., IIRC
broadcasts go through akka, and those may include things like Hadoop job
configuration and delegat
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60182360
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22051/consoleFull)
for PR 2739 at commit
[`fcc3d29`](https://github.com/a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60182365
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60177556
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22051/consoleFull)
for PR 2739 at commit
[`fcc3d29`](https://github.com/ap
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60177228
Jenkins, this is ok to test. Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user jacek-lewandowski commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60177158
@vanzin This PR doesn't secure data transfers anyway, because Spark uses
raw communication to exchange the real data. This is intended to secure mainly
control
Github user jacek-lewandowski commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60176829
I suppose that this is because this pr is not against the master branch
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60176777
(Seems like that only works for my own PRs, so this will probably need an
admin to trigger tests for you...)
---
If your project is set up for it, you can reply to this e
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60176191
Let me see if I can trigger tests for you - otherwise an admin will have to
intervene.
Also, let me think about the configuration thing some more. To be frank,
I'
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60176200
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user jacek-lewandowski commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-60175872
btw. @vanzin how to make Jenkins run the tests on this branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user jacek-lewandowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r19253270
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r19252433
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user jacek-lewandowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r19252007
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r19251701
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user jacek-lewandowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r19251575
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r19250068
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user jacek-lewandowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r19249681
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user jacek-lewandowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r19247143
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user jacek-lewandowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r19246989
--- Diff: conf/ssl.conf.template ---
@@ -0,0 +1,27 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contrib
Github user jacek-lewandowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r19246619
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r19246425
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user jacek-lewandowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r19245926
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user jacek-lewandowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r19244806
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -192,6 +196,44 @@ private[spark] class SecurityManager(sparkConf:
SparkC
Github user jacek-lewandowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r19244643
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -192,6 +196,44 @@ private[spark] class SecurityManager(sparkConf:
SparkC
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r19166051
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r19165851
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user jacek-lewandowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r19139861
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -18,7 +18,11 @@
package org.apache.spark
import java.net.
Github user jacek-lewandowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r19139794
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -192,6 +196,44 @@ private[spark] class SecurityManager(sparkConf:
SparkC
Github user jacek-lewandowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r19139582
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user jacek-lewandowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r19139391
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user jacek-lewandowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r19139237
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user jacek-lewandowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r19138979
--- Diff: conf/ssl.conf.template ---
@@ -0,0 +1,27 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
--- End di
Github user jacek-lewandowski commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-59431848
Thanks for review @vanzin
I will read all your comments soon, probably during a weekend... currently
a little bit overloaded
---
If your project is set up
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-59407360
Hi @jacek-lewandowski, I like this because it's trying to support more than
just the Web UI, but I think the configuration handling is sort of confusing
and overengineered
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r18975459
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -192,6 +196,44 @@ private[spark] class SecurityManager(sparkConf:
SparkConf) extend
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r18975351
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -18,7 +18,11 @@
package org.apache.spark
import java.net.{Authentica
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r18975378
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -192,6 +196,44 @@ private[spark] class SecurityManager(sparkConf:
SparkConf) extend
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r18975328
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -192,6 +196,44 @@ private[spark] class SecurityManager(sparkConf:
SparkConf) extend
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r18975159
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r18974920
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r18974767
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r18973684
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r18973129
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r18972906
--- Diff: conf/ssl.conf.template ---
@@ -0,0 +1,27 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor licens
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2739#discussion_r18972815
--- Diff: conf/ssl.conf.template ---
@@ -0,0 +1,27 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
--- End diff --
Github user jacek-lewandowski commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-58932802
I'll go through the discussion and changes in that ticket tomorrow morning,
thanks
---
If your project is set up for it, you can reply to this email and have y
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-58915520
#1980 is a PR to add SSL to the web UI, which might benefit from
SSLOptions. Do you want to comment on that PR's strategy for configuration,
etc?
---
If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-58594021
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
GitHub user jacek-lewandowski opened a pull request:
https://github.com/apache/spark/pull/2739
SPARK-3883 SSL support for HttpServer and Akka
- Introduced SSLOptions object
- SSLOptions is created by SecurityManager
- SSLOptions configures Akka and Jetty to use SSL
-
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2739#issuecomment-58594031
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
81 matches
Mail list logo
