Github user punya commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-112478521
Here's the relevant bit of the
[log](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34985/consoleFull)
(from testing #6842):
```
[error]
Github user punya commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-112474727
@rxin it looks like the branch-1.4 cherry-pick of this commit broke a unit
test, because it relies on `ExpressionEvalHelper` (which is absent on 1.4
afaik). I found this
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-112494629
Jenkins only run against master. Do you mind submitting a fix against
branch-1.4 for this? I will merge it.
---
If your project is set up for it, you can reply to this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-11015
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-11034
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-11163
[Test build #34961 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34961/consoleFull)
for PR 6793 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-112238819
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-112238803
[Test build #34961 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34961/console)
for PR 6793 at commit
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-112240939
Thanks. Merging in master branch-1.4.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/6793
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/6793#discussion_r32379130
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ArithmeticExpressionSuite.scala
---
@@ -69,6 +69,7 @@ class
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/6793#discussion_r32379114
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ArithmeticExpressionSuite.scala
---
@@ -69,6 +69,7 @@ class
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-111679430
Ok you managed to pick one suite that isn't a good example. Take a look at
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-111724468
I am trying to figure out how checkEvaluation should be used for the new
test.
protected def checkEvaluation(
expression: Expression, expected: Any,
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-111751601
Don't we have some way of setting the RNG seed for testing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-111751576
Looking at ArithmeticExpressionSuite.scala, it has some checks in the
following form:
checkDoubleEvaluation(c1 - c2, (-0.9 +- 0.001), row)
This seems to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-111752783
[Test build #34839 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34839/consoleFull)
for PR 6793 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-111752654
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-111752657
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-111758280
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-111758276
[Test build #34839 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34839/console)
for PR 6793 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6793#discussion_r32374653
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ArithmeticExpressionSuite.scala
---
@@ -69,6 +69,7 @@ class
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6793#discussion_r32374656
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ArithmeticExpressionSuite.scala
---
@@ -69,6 +69,7 @@ class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-111667284
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-111663330
We should create a RandomSuite.scala in expressions, and add tests for
that. Take a look at other suites in that package.
---
If your project is set up for it, you can
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-111668224
I looked at UnsafeFixedWidthAggregationMapSuite.scala in expressions
package.
Is RandomSuite.scala going to test Rand and Randn only ?
A bit more hint is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-111655066
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-111655070
can you please add a test case to prevent regression
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-111655061
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-111654917
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-111655373
Mind telling me which suite the new test should be added to ?
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-111657774
At first glance, none of the test suites under
sql/catalyst/src/test//scala/org/apache/spark/sql seems proper for the new test.
---
If your project is set up for it, you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6793#issuecomment-111648902
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
33 matches
Mail list logo
