Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13778
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r70198204
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -346,14 +346,47 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r70197828
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -346,14 +346,47 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r70197819
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -346,14 +346,47 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r70197694
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -346,14 +346,47 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r70197480
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -346,14 +346,47 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r70197423
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -346,14 +346,47 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r70196570
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -346,14 +346,47 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r69863023
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -374,13 +407,15 @@ object MapObjects {
*
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r69844600
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -374,13 +407,15 @@ object MapObjects {
*
Github user vlad17 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r69758782
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -374,13 +407,15 @@ object MapObjects {
*
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r69699166
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -346,14 +346,47 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r69698991
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -346,14 +346,38 @@ case class
Github user vlad17 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r68979443
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -346,14 +346,38 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r68879222
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -349,11 +349,12 @@ object MapObjects {
Github user vlad17 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r68789054
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -349,11 +349,12 @@ object MapObjects {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r68778347
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -427,8 +430,9 @@ case class MapObjects private(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r68586050
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -427,8 +427,12 @@ case class MapObjects
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r68585682
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -427,8 +427,12 @@ case class MapObjects
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r68584282
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -427,8 +427,12 @@ case class MapObjects
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r68578656
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -427,8 +427,12 @@ case class MapObjects
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r68570943
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -427,8 +427,12 @@ case class MapObjects
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r68548168
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -427,8 +427,12 @@ case class MapObjects
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r68546922
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -427,8 +427,12 @@ case class MapObjects
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r68546826
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -427,8 +427,12 @@ case class MapObjects
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r68488418
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -427,8 +427,12 @@ case class MapObjects
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r68487666
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -427,8 +427,12 @@ case class MapObjects
Github user vlad17 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r68416995
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -427,8 +427,12 @@ case class MapObjects
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r68404320
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -427,8 +427,12 @@ case class MapObjects
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r68385069
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -427,8 +427,12 @@ case class MapObjects
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r67984779
--- Diff: python/pyspark/sql/tests.py ---
@@ -558,6 +558,18 @@ def check_datatype(datatype):
_verify_type(PythonOnlyPoint(1.0, 2.0),
Github user vlad17 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r67894974
--- Diff: python/pyspark/sql/tests.py ---
@@ -558,6 +558,18 @@ def check_datatype(datatype):
_verify_type(PythonOnlyPoint(1.0, 2.0),
Github user vlad17 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r67894797
--- Diff: python/pyspark/sql/tests.py ---
@@ -558,6 +558,18 @@ def check_datatype(datatype):
_verify_type(PythonOnlyPoint(1.0, 2.0),
Github user vlad17 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r67894457
--- Diff: python/pyspark/sql/tests.py ---
@@ -558,6 +558,18 @@ def check_datatype(datatype):
_verify_type(PythonOnlyPoint(1.0, 2.0),
Github user vlad17 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r67894162
--- Diff: python/pyspark/sql/tests.py ---
@@ -558,6 +558,18 @@ def check_datatype(datatype):
_verify_type(PythonOnlyPoint(1.0, 2.0),
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r67784246
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -427,8 +427,12 @@ case class MapObjects
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r67719911
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -220,9 +220,15 @@ object RowEncoder {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r67710677
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -427,8 +427,12 @@ case class MapObjects
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r67710501
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -427,8 +427,12 @@ case class MapObjects
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r67699433
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -220,9 +220,15 @@ object RowEncoder {
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r67698506
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -220,9 +220,15 @@ object RowEncoder {
41 matches
Mail list logo
