[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73694456 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -301,9 +298,6 @@ case class AlterTableSerDePropertiesCommand(

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73644536 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -374,20 +373,7 @@ private[hive] class HiveClientImpl(

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73644517 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -70,64 +69,16 @@ private[hive] class HiveMetastoreCatalog(spa

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73644322 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -506,76 +495,16 @@ object DDLUtils { } /**

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73644259 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -275,238 +269,21 @@ case class CreateDataSour

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73639529 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -301,9 +298,6 @@ case class AlterTableSerDePropertiesCommand(

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73633166 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -275,238 +269,21 @@ case class CreateDataSourceTa

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73623682 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -301,9 +298,6 @@ case class AlterTableSerDePropertiesCommand(

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73623489 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -229,10 +230,8 @@ case class AlterTableSetPropertiesCommand( e

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73623449 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -229,10 +230,8 @@ case class AlterTableSetPropertiesCommand( e

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73622711 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/HiveSerDe.scala --- @@ -42,8 +41,7 @@ object HiveSerDe { HiveSerDe(

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73508367 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -1032,11 +977,6 @@ class DDLSuite extends QueryTest with S

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73164253 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -301,9 +298,6 @@ case class AlterTableSerDePropertiesCommand(

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r73163246 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -119,12 +119,9 @@ case class CreateTableLikeCommand( case

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-07-31 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r72930383 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -359,40 +357,6 @@ class DDLSuite extends QueryTest with Sha

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-07-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r71461308 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -153,15 +157,113 @@ private[spark] class HiveExternalCatalog(

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-07-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r71461226 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -153,15 +157,113 @@ private[spark] class HiveExternalCatalog(

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-07-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r71454038 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/HiveSerDe.scala --- @@ -42,8 +41,7 @@ object HiveSerDe { HiveSerDe(

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-07-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r71420308 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/HiveSerDe.scala --- @@ -42,8 +41,7 @@ object HiveSerDe { HiveSerDe(

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-07-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r71418299 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -153,15 +157,113 @@ private[spark] class HiveExternalCatalog(

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-07-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r71361405 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -153,15 +157,113 @@ private[spark] class HiveExternalCatalog(c

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-07-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r71361074 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/HiveSerDe.scala --- @@ -42,8 +41,7 @@ object HiveSerDe { HiveSerDe(

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-07-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r71359307 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -136,15 +141,14 @@ case class CatalogTable( co

<    1   2