Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14384
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r75440356
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,146 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r75408767
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,146 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
function(object,
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r75290436
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,146 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r75273184
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -454,4 +454,61 @@ test_that("spark.survreg", {
}
})
+test_that("spark.als", {
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r75272624
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/ALSWrapper.scala ---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r75272474
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/ALSWrapper.scala ---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r75233142
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/ALSWrapper.scala ---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r75181798
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -454,4 +454,61 @@ test_that("spark.survreg", {
}
})
+test_that("spark.als", {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r75179320
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/ALSWrapper.scala ---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r75179030
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/ALSWrapper.scala ---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r75178881
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/ALSWrapper.scala ---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r75178780
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/ALSWrapper.scala ---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r75178434
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/ALSWrapper.scala ---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r75004906
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -454,4 +454,61 @@ test_that("spark.survreg", {
}
})
+test_that("spark.als", {
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r74999004
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,159 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
function(object,
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r74868483
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,159 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r74868437
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,159 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r74867735
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,159 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r74867708
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,159 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r74674616
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,159 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r74527111
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,159 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r74528252
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,159 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r74537542
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,159 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
function(object,
Github user NarineK commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r74551161
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -454,4 +454,61 @@ test_that("spark.survreg", {
}
})
+test_that("spark.als", {
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r74536489
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,159 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
function(object,
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r74527784
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,159 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r74527216
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,159 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r74116056
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,147 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
function(object,
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r74112930
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,147 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
function(object,
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r74009550
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,147 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
function(object,
Github user NarineK commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r73999377
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,147 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
function(object,
Github user NarineK commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r73999041
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,147 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
function(object,
Github user NarineK commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r73998522
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,147 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
function(object,
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r72880604
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -454,4 +454,48 @@ test_that("spark.survreg", {
}
})
+test_that("spark.als",
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r72880581
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,137 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r72880583
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,137 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r72880568
--- Diff: R/pkg/R/mllib.R ---
@@ -632,3 +642,137 @@ setMethod("predict", signature(object =
"AFTSurvivalRegressionModel"),
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14384#discussion_r72880558
--- Diff: R/pkg/R/mllib.R ---
@@ -61,7 +68,7 @@ setClass("KMeansModel", representation(jobj = "jobj"))
#' @name write.ml
#' @export
#'
GitHub user junyangq opened a pull request:
https://github.com/apache/spark/pull/14384
[Spark-16443][SparkR] Alternating Least Squares (ALS) wrapper
## What changes were proposed in this pull request?
Add Alternating Least Squares wrapper in SparkR. Unit tests have been
40 matches
Mail list logo
