Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14482
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73643735
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -420,45 +420,40 @@ private[sql] abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73638320
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala ---
@@ -272,18 +259,15 @@ class CatalogImpl(sparkSession: SparkSession)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73574347
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala ---
@@ -272,18 +259,15 @@ class CatalogImpl(sparkSession: SparkSession)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73568017
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -420,45 +420,40 @@ private[sql] abstract class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73557584
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala ---
@@ -272,18 +259,15 @@ class CatalogImpl(sparkSession: SparkSession)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73553259
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala ---
@@ -223,20 +223,7 @@ class CatalogImpl(sparkSession: SparkSession)
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73478952
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -319,12 +319,26 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73478351
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -420,45 +420,40 @@ private[sql] abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73478108
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLCommandSuite.scala
---
@@ -329,47 +328,29 @@ class DDLCommandSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73478093
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLCommandSuite.scala
---
@@ -329,47 +328,29 @@ class DDLCommandSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73477850
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -319,12 +319,26 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73477314
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -319,12 +319,26 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73476814
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -420,45 +420,40 @@ private[sql] abstract class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73475935
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -154,6 +274,21 @@ private[sql] case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73474964
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -420,45 +420,40 @@ private[sql] abstract class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73474573
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -319,12 +319,26 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73474139
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -367,15 +368,16 @@ final class DataFrameWriter[T] private[sql](ds:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73472950
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -933,23 +933,6 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73472871
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -933,23 +933,6 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73471840
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -62,6 +66,122 @@ private[sql] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73471330
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -933,23 +933,6 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73471131
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -62,6 +66,122 @@ private[sql] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73470304
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -933,23 +933,6 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73469783
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -62,6 +66,122 @@ private[sql] class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73469639
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -933,23 +933,6 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73469309
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -62,6 +66,122 @@ private[sql] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73468039
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -933,23 +933,6 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73467801
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -933,23 +933,6 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73467821
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -62,6 +66,122 @@ private[sql] class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73467467
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -62,6 +66,122 @@ private[sql] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73467397
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -206,22 +206,22 @@ private[sql] case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73466961
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -62,6 +66,122 @@ private[sql] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73466174
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -933,23 +933,6 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73465089
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ddl.scala ---
@@ -19,50 +19,25 @@ package
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73464594
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -154,6 +274,21 @@ private[sql] case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73464308
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -206,22 +206,22 @@ private[sql] case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73464228
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -62,6 +66,122 @@ private[sql] class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73464090
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -420,45 +420,40 @@ private[sql] abstract class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73461786
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -233,12 +233,11 @@ private[sql] case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73461643
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -233,12 +233,11 @@ private[sql] case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73461508
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -206,22 +206,22 @@ private[sql] case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73458290
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -367,15 +368,16 @@ final class DataFrameWriter[T] private[sql](ds:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73457639
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -61,6 +64,38 @@ trait CheckAnalysis extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73457371
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -349,6 +384,27 @@ trait CheckAnalysis extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73408103
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -61,6 +64,38 @@ trait CheckAnalysis extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73390262
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -420,45 +420,40 @@ private[sql] abstract class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73389058
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -420,45 +420,40 @@ private[sql] abstract class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73388435
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -367,15 +368,16 @@ final class DataFrameWriter[T] private[sql](ds:
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73387761
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -112,6 +111,8 @@ case class BucketSpec(
* Note
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73387447
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -349,6 +384,27 @@ trait CheckAnalysis extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73387263
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -349,6 +384,27 @@ trait CheckAnalysis extends
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/14482
[SPARK-16879][SQL] unify logical plans for CREATE TABLE and CTAS
## What changes were proposed in this pull request?
we have various logical plans for CREATE TABLE and CTAS:
53 matches
Mail list logo
