[GitHub] spark pull request #14638: [SPARK-11374][SQL] Support `skip.header.line.coun...

Github user dongjoon-hyun closed the pull request at: https://github.com/apache/spark/pull/14638 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #14638: [SPARK-11374][SQL] Support `skip.header.line.coun...

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14638#discussion_r91383183 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala --- @@ -113,6 +113,9 @@ class HadoopTableReader( val

[GitHub] spark pull request #14638: [SPARK-11374][SQL] Support `skip.header.line.coun...

Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/14638#discussion_r91332545 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala --- @@ -122,10 +125,22 @@ class HadoopTableReader( val attrsWithIndex

[GitHub] spark pull request #14638: [SPARK-11374][SQL] Support `skip.header.line.coun...

Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/14638#discussion_r91331724 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala --- @@ -113,6 +113,9 @@ class HadoopTableReader( val tablePath

[GitHub] spark pull request #14638: [SPARK-11374][SQL] Support `skip.header.line.coun...

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14638#discussion_r90584660 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -2011,6 +2011,54 @@ class SQLQuerySuite extends

[GitHub] spark pull request #14638: [SPARK-11374][SQL] Support `skip.header.line.coun...

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14638#discussion_r90123854 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala --- @@ -113,6 +113,10 @@ class HadoopTableReader( val

[GitHub] spark pull request #14638: [SPARK-11374][SQL] Support `skip.header.line.coun...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14638#discussion_r90112125 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala --- @@ -113,6 +113,10 @@ class HadoopTableReader( val tablePath

[GitHub] spark pull request #14638: [SPARK-11374][SQL] Support `skip.header.line.coun...

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14638#discussion_r90101517 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala --- @@ -122,10 +126,20 @@ class HadoopTableReader( val

[GitHub] spark pull request #14638: [SPARK-11374][SQL] Support `skip.header.line.coun...

Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14638#discussion_r90098793 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala --- @@ -122,10 +126,20 @@ class HadoopTableReader( val attrsWithIndex =

[GitHub] spark pull request #14638: [SPARK-11374][SQL] Support `skip.header.line.coun...

Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14638#discussion_r90098551 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala --- @@ -122,10 +126,20 @@ class HadoopTableReader( val attrsWithIndex =

[GitHub] spark pull request #14638: [SPARK-11374][SQL] Support `skip.header.line.coun...

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14638#discussion_r90095923 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala --- @@ -113,6 +113,10 @@ class HadoopTableReader( val

[GitHub] spark pull request #14638: [SPARK-11374][SQL] Support `skip.header.line.coun...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14638#discussion_r90063348 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala --- @@ -113,6 +113,10 @@ class HadoopTableReader( val tablePath

[GitHub] spark pull request #14638: [SPARK-11374][SQL] Support `skip.header.line.coun...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14638#discussion_r90063628 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala --- @@ -122,10 +126,20 @@ class HadoopTableReader( val attrsWithIndex

[GitHub] spark pull request #14638: [SPARK-11374][SQL] Support `skip.header.line.coun...

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14638#discussion_r87878854 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala --- @@ -122,10 +126,18 @@ class HadoopTableReader( val

[GitHub] spark pull request #14638: [SPARK-11374][SQL] Support `skip.header.line.coun...

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14638#discussion_r87876602 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala --- @@ -113,6 +113,10 @@ class HadoopTableReader( val

[GitHub] spark pull request #14638: [SPARK-11374][SQL] Support `skip.header.line.coun...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14638#discussion_r87874812 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala --- @@ -113,6 +113,10 @@ class HadoopTableReader( val tablePath

[GitHub] spark pull request #14638: [SPARK-11374][SQL] Support `skip.header.line.coun...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14638#discussion_r87874770 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala --- @@ -113,6 +113,10 @@ class HadoopTableReader( val tablePath

[GitHub] spark pull request #14638: [SPARK-11374][SQL] Support `skip.header.line.coun...

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14638#discussion_r87875211 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala --- @@ -122,10 +126,18 @@ class HadoopTableReader( val attrsWithIndex

[GitHub] spark pull request #14638: [SPARK-11374][SQL] Support `skip.header.line.coun...

GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/14638 [SPARK-11374][SQL] Support `skip.header.line.count` option in Hive External Table ## What changes were proposed in this pull request? Since CSV files have one or more header lines