[GitHub] spark pull request #14856: [SPARK-17241][SparkR][MLlib] SparkR spark.glm sho...

2016-08-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14856 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14856: [SPARK-17241][SparkR][MLlib] SparkR spark.glm sho...

2016-08-30 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14856#discussion_r76844386 --- Diff: R/pkg/inst/tests/testthat/test_mllib.R --- @@ -99,6 +99,10 @@ test_that("spark.glm summary", { expect_match(out[2], "Deviance Residuals:")

[GitHub] spark pull request #14856: [SPARK-17241][SparkR][MLlib] SparkR spark.glm sho...

2016-08-30 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14856#discussion_r76844264 --- Diff: R/pkg/inst/tests/testthat/test_mllib.R --- @@ -99,6 +99,10 @@ test_that("spark.glm summary", { expect_match(out[2], "Deviance Residuals:")

[GitHub] spark pull request #14856: [SPARK-17241][SparkR][MLlib] SparkR spark.glm sho...

2016-08-30 Thread keypointt
Github user keypointt commented on a diff in the pull request: https://github.com/apache/spark/pull/14856#discussion_r76842594 --- Diff: R/pkg/inst/tests/testthat/test_mllib.R --- @@ -99,6 +99,10 @@ test_that("spark.glm summary", { expect_match(out[2], "Deviance Residuals:")

[GitHub] spark pull request #14856: [SPARK-17241][SparkR][MLlib] SparkR spark.glm sho...

2016-08-30 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14856#discussion_r76841246 --- Diff: R/pkg/inst/tests/testthat/test_mllib.R --- @@ -99,6 +99,10 @@ test_that("spark.glm summary", { expect_match(out[2], "Deviance Residuals:")

[GitHub] spark pull request #14856: [SPARK-17241][SparkR][MLlib] SparkR spark.glm sho...

2016-08-29 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14856#discussion_r76669742 --- Diff: R/pkg/R/mllib.R --- @@ -171,7 +172,8 @@ predict_internal <- function(object, newData) { #' @note spark.glm since 2.0.0 #' @seealso

[GitHub] spark pull request #14856: [SPARK-17241][SparkR][MLlib] SparkR spark.glm sho...

2016-08-28 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14856#discussion_r76553172 --- Diff: R/pkg/R/mllib.R --- @@ -171,7 +172,8 @@ predict_internal <- function(object, newData) { #' @note spark.glm since 2.0.0 #' @seealso

[GitHub] spark pull request #14856: [SPARK-17241][SparkR][MLlib] SparkR spark.glm sho...

2016-08-28 Thread keypointt
Github user keypointt commented on a diff in the pull request: https://github.com/apache/spark/pull/14856#discussion_r76552881 --- Diff: R/pkg/R/mllib.R --- @@ -171,7 +172,8 @@ predict_internal <- function(object, newData) { #' @note spark.glm since 2.0.0 #' @seealso

[GitHub] spark pull request #14856: [SPARK-17241][SparkR][MLlib] SparkR spark.glm sho...

2016-08-28 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14856#discussion_r76552745 --- Diff: R/pkg/R/mllib.R --- @@ -171,7 +172,8 @@ predict_internal <- function(object, newData) { #' @note spark.glm since 2.0.0 #' @seealso

[GitHub] spark pull request #14856: [SPARK-17241][SparkR][MLlib] SparkR spark.glm sho...

2016-08-28 Thread keypointt
GitHub user keypointt opened a pull request: https://github.com/apache/spark/pull/14856 [SPARK-17241][SparkR][MLlib] SparkR spark.glm should have configurable regularization parameter https://issues.apache.org/jira/browse/SPARK-17241 ## What changes were proposed in this