Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16246#discussion_r101618460
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -136,24 +140,35 @@ trait CheckAnalysis extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16246#discussion_r92450051
--- Diff: sql/core/src/test/resources/sql-tests/inputs/scalar-subquery.sql
---
@@ -0,0 +1,20 @@
+CREATE OR REPLACE TEMPORARY VIEW p AS VALUES (1, 1)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16246#discussion_r92447441
--- Diff: sql/core/src/test/resources/sql-tests/inputs/scalar-subquery.sql
---
@@ -0,0 +1,20 @@
+CREATE OR REPLACE TEMPORARY VIEW p AS VALUES (1, 1)
Github user nsyca commented on a diff in the pull request:
https://github.com/apache/spark/pull/16246#discussion_r92425497
--- Diff: sql/core/src/test/resources/sql-tests/inputs/scalar-subquery.sql
---
@@ -0,0 +1,20 @@
+CREATE OR REPLACE TEMPORARY VIEW p AS VALUES (1, 1) AS
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16246#discussion_r92421093
--- Diff: sql/core/src/test/resources/sql-tests/inputs/scalar-subquery.sql
---
@@ -0,0 +1,20 @@
+CREATE OR REPLACE TEMPORARY VIEW p AS VALUES (1, 1)
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16246
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16246#discussion_r92286561
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -136,24 +142,36 @@ trait CheckAnalysis extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16246#discussion_r92285487
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -124,6 +124,12 @@ trait CheckAnalysis extends
Github user nsyca commented on a diff in the pull request:
https://github.com/apache/spark/pull/16246#discussion_r92041145
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1225,15 +1225,34 @@ class Analyzer(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16246#discussion_r91972320
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1225,15 +1225,34 @@ class Analyzer(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16246#discussion_r91848250
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1225,15 +1225,37 @@ class Analyzer(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16246#discussion_r91848198
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1225,15 +1225,37 @@ class Analyzer(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16246#discussion_r91848190
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1225,15 +1225,37 @@ class Analyzer(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16246#discussion_r91840831
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1230,10 +1230,24 @@ class Analyzer(
*/
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16246#discussion_r91840568
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1230,10 +1230,24 @@ class Analyzer(
*/
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16246#discussion_r91840552
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1230,10 +1230,24 @@ class Analyzer(
*/
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16246#discussion_r91840532
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala
---
@@ -495,6 +495,17 @@ class SubquerySuite extends QueryTest with
Github user nsyca commented on a diff in the pull request:
https://github.com/apache/spark/pull/16246#discussion_r91840504
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1230,10 +1230,24 @@ class Analyzer(
*/
GitHub user nsyca reopened a pull request:
https://github.com/apache/spark/pull/16246
[SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32
## What changes were proposed in this pull request?
Move the checking of GROUP BY column in correlated scalar subquery from
Github user nsyca closed the pull request at:
https://github.com/apache/spark/pull/16246
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16246#discussion_r91840395
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1230,10 +1230,24 @@ class Analyzer(
*/
Github user nsyca commented on a diff in the pull request:
https://github.com/apache/spark/pull/16246#discussion_r91840347
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1230,10 +1230,24 @@ class Analyzer(
*/
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16246#discussion_r91840263
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1230,10 +1230,24 @@ class Analyzer(
*/
GitHub user nsyca opened a pull request:
https://github.com/apache/spark/pull/16246
[SPARK-18814][SQL] CheckAnalysis rejects TPCDS query 32
## What changes were proposed in this pull request?
Move the checking of GROUP BY column in correlated scalar subquery from
24 matches
Mail list logo
