Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16308
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97935192
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -250,6 +252,8 @@ class Dataset[T] private[sql](
val hasMoreData =
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97934467
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
---
@@ -177,180 +177,186 @@ class DateTimeUtilsSuite
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97934459
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -107,108 +109,119 @@ class CastSuite extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97934309
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1056,7 +1057,8 @@ object DecimalAggregates extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97934297
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -490,7 +569,11 @@ abstract class UnixTime
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97934304
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1044,7 +1044,8 @@ object DecimalAggregates extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97807866
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -250,6 +252,8 @@ class Dataset[T] private[sql](
val hasMoreData =
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97749254
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1044,7 +1044,8 @@ object DecimalAggregates extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97749273
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1056,7 +1057,8 @@ object DecimalAggregates extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97808039
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
---
@@ -177,180 +177,186 @@ class DateTimeUtilsSuite
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97748329
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -490,7 +569,11 @@ abstract class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97801907
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -107,108 +109,119 @@ class CastSuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97753392
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -490,7 +569,11 @@ abstract class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97708190
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -475,6 +1164,45 @@ class DateFunctionsSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97556081
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -475,6 +1164,45 @@ class DateFunctionsSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97554829
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -475,6 +1164,45 @@ class DateFunctionsSuite extends QueryTest with
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97490521
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -475,6 +1164,45 @@ class DateFunctionsSuite extends QueryTest with
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97482071
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -103,6 +153,51 @@ class DateFunctionsSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97346228
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -475,6 +1164,45 @@ class DateFunctionsSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97338806
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -103,6 +153,51 @@ class DateFunctionsSuite extends QueryTest with
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97338104
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -69,11 +70,28 @@ class DateFunctionsSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97330451
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -69,11 +70,28 @@ class DateFunctionsSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97326027
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -480,7 +558,8 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97325962
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -465,10 +536,17 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97221574
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -69,49 +69,68 @@ object DateTimeUtils {
}
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97220276
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningAwareFileIndex.scala
---
@@ -137,7 +138,8 @@ abstract class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97220274
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
---
@@ -314,7 +315,7 @@ object FileFormatWriter extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97220270
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/OptimizeMetadataOnlyQuery.scala
---
@@ -104,7 +105,8 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97220249
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -250,6 +252,8 @@ class Dataset[T] private[sql](
val hasMoreData =
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97220246
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -260,6 +264,10 @@ class Dataset[T] private[sql](
case binary:
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97219588
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
---
@@ -177,180 +177,186 @@ class DateTimeUtilsSuite
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97219579
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -107,108 +109,119 @@ class CastSuite extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97219583
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
---
@@ -143,72 +159,114 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97218906
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -139,27 +140,15 @@ class QueryExecution(val sparkSession:
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97218917
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -869,6 +870,30 @@ class DataFrameSuite extends QueryTest with
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97218919
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -69,11 +70,26 @@ class DateFunctionsSuite extends QueryTest with
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97218902
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -200,8 +189,10 @@ class QueryExecution(val sparkSession:
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97218909
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -655,6 +655,11 @@ object SQLConf {
.booleanConf
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97218889
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
---
@@ -238,7 +297,8 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r9721
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
---
@@ -219,7 +277,8 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97218892
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -177,7 +177,7 @@ class Column(val expr: Expression) extends Logging {
//
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97218882
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -316,30 +329,43 @@ class CastSuite extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97218807
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -69,49 +69,68 @@ object DateTimeUtils {
}
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97218801
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -60,7 +60,7 @@ object DateTimeUtils {
final val
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96631900
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -103,6 +150,27 @@ class DateFunctionsSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96631616
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -91,6 +107,37 @@ class DateFunctionsSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96631280
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -69,11 +70,26 @@ class DateFunctionsSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96631159
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -869,6 +870,30 @@ class DataFrameSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96630662
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -655,6 +655,11 @@ object SQLConf {
.booleanConf
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96630541
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningAwareFileIndex.scala
---
@@ -137,7 +138,8 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96630262
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
---
@@ -314,7 +315,7 @@ object FileFormatWriter
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96630066
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -139,27 +140,15 @@ class QueryExecution(val sparkSession:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96629902
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -200,8 +189,10 @@ class QueryExecution(val sparkSession:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96629686
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/OptimizeMetadataOnlyQuery.scala
---
@@ -104,7 +105,8 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96629536
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -250,6 +252,8 @@ class Dataset[T] private[sql](
val hasMoreData =
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96629481
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -260,6 +264,10 @@ class Dataset[T] private[sql](
case binary:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96629155
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -177,7 +177,7 @@ class Column(val expr: Expression) extends Logging {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96628885
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
---
@@ -177,180 +177,186 @@ class DateTimeUtilsSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96628249
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
---
@@ -238,7 +297,8 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96628209
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
---
@@ -219,7 +277,8 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96628119
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
---
@@ -143,72 +159,114 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96628068
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
---
@@ -143,72 +159,114 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96627882
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
---
@@ -143,72 +159,114 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96626960
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -316,30 +329,43 @@ class CastSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96626629
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -107,108 +109,119 @@ class CastSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96625855
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -60,7 +60,7 @@ object DateTimeUtils {
final
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96625166
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -69,49 +69,68 @@ object DateTimeUtils {
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96625070
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -69,49 +69,68 @@ object DateTimeUtils {
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96624752
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -60,7 +60,7 @@ object DateTimeUtils {
final
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96624020
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -544,12 +630,15 @@ abstract class
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96482971
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -30,21 +30,42 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96359512
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -30,21 +30,42 @@ import
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96260869
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -107,6 +107,7 @@ package object dsl {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96222178
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -107,6 +107,7 @@ package object dsl {
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96179000
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -316,30 +329,43 @@ class CastSuite extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96178803
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -195,19 +231,26 @@ case class Hour(child:
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96178830
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -32,20 +34,20 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96171888
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -316,30 +329,43 @@ class CastSuite extends
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96171901
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala
---
@@ -41,13 +46,18 @@ object ReplaceExpressions extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96171760
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -32,20 +34,20 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96171393
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -195,19 +231,26 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96171142
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala
---
@@ -41,13 +46,18 @@ object ReplaceExpressions
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r95716928
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -111,7 +112,8 @@ case class CatalogTablePartition(
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r95686129
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -111,7 +112,8 @@ case class CatalogTablePartition(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r95596550
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -111,7 +112,8 @@ case class CatalogTablePartition(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r95593914
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -111,7 +112,8 @@ case class CatalogTablePartition(
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r95514328
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -30,21 +30,48 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r95513821
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -30,21 +30,48 @@ import
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r95508829
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -30,21 +30,48 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r95408770
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -30,21 +30,48 @@ import
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r95400434
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -512,8 +550,9 @@ case class Cast(child: Expression,
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r95400468
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -30,21 +30,48 @@ import
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r95400494
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -30,21 +30,48 @@ import
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r95400453
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -30,21 +30,48 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r95345089
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -30,21 +30,48 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r95345004
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -30,21 +30,48 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r95344871
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -30,21 +30,48 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r95340855
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -512,8 +550,9 @@ case class Cast(child: Expression,
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r93811889
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
---
@@ -288,7 +289,7 @@ object FileFormatWriter extends
1 - 100 of 110 matches
Mail list logo
