[GitHub] spark pull request #16736: [WIP][SPARK][SQL][Follow-up] Configurable `tableR...

2017-01-31 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r98836889 --- Diff: core/src/main/scala/org/apache/spark/internal/config/ConfigBuilder.scala --- @@ -90,6 +90,14 @@ private[spark] class TypedConfigBuilder[T](

[GitHub] spark pull request #16736: [WIP][SPARK][SQL][Follow-up] Configurable `tableR...

2017-01-31 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r98836570 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -221,6 +221,10 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request #16736: [WIP][SPARK][SQL][Follow-up] Configurable `tableR...

2017-01-30 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r98592980 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -221,17 +221,8 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request #16736: [WIP][SPARK][SQL][Follow-up] Configurable `tableR...

2017-01-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r98589964 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -464,6 +464,16 @@ object SQLConf { .intConf

[GitHub] spark pull request #16736: [WIP][SPARK][SQL][Follow-up] Configurable `tableR...

2017-01-30 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r98589474 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -464,6 +464,16 @@ object SQLConf { .intConf

[GitHub] spark pull request #16736: [WIP][SPARK][SQL][Follow-up] Configurable `tableR...

2017-01-30 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r98589278 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -221,6 +221,19 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request #16736: [WIP][SPARK][SQL][Follow-up] Configurable `tableR...

2017-01-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r98522244 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -221,6 +221,19 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request #16736: [WIP][SPARK][SQL][Follow-up] Configurable `tableR...

2017-01-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r98521412 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -464,6 +464,16 @@ object SQLConf { .intConf

[GitHub] spark pull request #16736: [WIP][SPARK][SQL][Follow-up] Configurable `tableR...

2017-01-29 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r98375909 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -464,6 +464,12 @@ object SQLConf { .intConf

[GitHub] spark pull request #16736: [WIP][SPARK][SQL][Follow-up] Configurable `tableR...

2017-01-29 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r98375736 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystConf.scala --- @@ -69,6 +71,7 @@ case class SimpleCatalystConf(

[GitHub] spark pull request #16736: [WIP][SPARK][SQL][Follow-up] Configurable `tableR...

2017-01-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r98375256 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystConf.scala --- @@ -69,6 +71,7 @@ case class SimpleCatalystConf(

[GitHub] spark pull request #16736: [WIP][SPARK][SQL][Follow-up] Configurable `tableR...

2017-01-29 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r98374466 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystConf.scala --- @@ -69,6 +71,7 @@ case class SimpleCatalystConf(

[GitHub] spark pull request #16736: [WIP][SPARK][SQL][Follow-up] Configurable `tableR...

2017-01-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r98373692 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -464,6 +464,12 @@ object SQLConf { .intConf

[GitHub] spark pull request #16736: [WIP][SPARK][SQL][Follow-up] Configurable `tableR...

2017-01-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r98373650 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -464,6 +464,12 @@ object SQLConf { .intConf

[GitHub] spark pull request #16736: [WIP][SPARK][SQL][Follow-up] Configurable `tableR...

2017-01-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r98373609 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystConf.scala --- @@ -69,6 +71,7 @@ case class SimpleCatalystConf(

[GitHub] spark pull request #16736: [WIP][SPARK][SQL][Follow-up] Configurable `tableR...

2017-01-29 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/16736 [WIP][SPARK][SQL][Follow-up] Configurable `tableRelationCache` maximum size ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How